fixed per pr comments

Author: Holly Williams

send-surveys/src/main/java/com/objectcomputing/pulsesurvey/receive/responses/SurveyResponseController.java

@@ -115,8 +115,7 @@ public HttpResponse sendThankYouWithCommentBlock (String userComments, String su
         LOG.info("With surveyKey: " + surveyKey);
         // put comment into the db using the survey key
 
-        boolean commentSaved = saveUserComment(surveyKey, userComments);
-        LOG.info("commentSaved: " + commentSaved);
+        saveUserComment(surveyKey, userComments);
 
         return HttpResponse.ok();
     }
@@ -174,7 +173,7 @@ private boolean checkForComment(String surveyKey) {
 
     }
 
-    boolean saveUserComment(String surveyKey, String comments) {
+    void saveUserComment(String surveyKey, String comments) {
 
         boolean commentsAdded = false;
         UserComments userComments = new UserComments();
@@ -186,7 +185,6 @@ boolean saveUserComment(String surveyKey, String comments) {
 
         if (userComments.getCommentId() != null) commentsAdded = true;
 
-        return commentsAdded;
     }
 
     ResponseKey markKeyAsUsed(String surveyKey) {

send-surveys/src/test/java/com/objectcomputing/pulsesurvey/receive/responses/SurveyResponseControllerTest.java

@@ -1,7 +1,5 @@
 package com.objectcomputing.pulsesurvey.receive.responses;
 
-import com.fasterxml.jackson.core.JsonProcessingException;
-import com.fasterxml.jackson.databind.ObjectMapper;
 import com.objectcomputing.pulsesurvey.email.manager.GmailSender;
 import com.objectcomputing.pulsesurvey.model.Response;
 import com.objectcomputing.pulsesurvey.model.ResponseKey;
@@ -10,9 +8,7 @@
 import com.objectcomputing.pulsesurvey.repositories.ResponseRepository;
 import com.objectcomputing.pulsesurvey.repositories.UserCommentsRepository;
 import com.objectcomputing.pulsesurvey.send.surveys.SurveysControllerTest;
-import com.objectcomputing.pulsesurvey.template.manager.SurveyTemplateManager;
 import io.micronaut.core.io.buffer.ByteBuffer;
-import io.micronaut.core.util.CollectionUtils;
 import io.micronaut.http.HttpRequest;
 import io.micronaut.http.HttpResponse;
 import io.micronaut.http.HttpStatus;
@@ -28,18 +24,21 @@
 import org.slf4j.LoggerFactory;
 
 import javax.inject.Inject;
-
 import java.time.LocalDateTime;
 import java.time.Month;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Optional;
 import java.util.UUID;
 
-import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.reset;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
 @ExtendWith(SystemPropertyExtension.class)
@@ -243,7 +242,8 @@ void testSaveUserComment() {
 
         when(mockUserCommentsRepository.save(any())).thenReturn(fakeUserComments);
 
-        assertTrue(itemUnderTest.saveUserComment(surveyKey, fakeComments));
+        itemUnderTest.saveUserComment(surveyKey, fakeComments);
+        verify(mockUserCommentsRepository, times(1)).save(any(UserComments.class));
 
     }
 
@@ -267,10 +267,6 @@ void testSendThankYouWithCommentBlock() {
 
         when(mockUserCommentsRepository.save(any())).thenReturn(fakeUserComments);
 
-//todo should we just call this directly?
-//        HttpResponse resp = itemUnderTest.sendThankYouWithCommentBlock(userComments, surveyKey);
-//        assertEquals(HttpStatus.OK, resp.getStatus());
-
         HttpResponse response = httpClient
                 .exchange(HttpRequest.POST("/happiness/userComments", fakeBody)
                 .contentType(MediaType.APPLICATION_FORM_URLENCODED))