refactor: enable ESLint Wave 1 rules (prefer-const, no-useless-catch, no-empty) and fix all violations

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

eslint.config.mjs

@@ -15,10 +15,10 @@ export default tseslint.config(
           "@typescript-eslint/no-empty-object-type": "off",
           "no-case-declarations": "off",
           "no-useless-escape": "off",
-          "prefer-const": "off",
-          "no-empty": "off",
+          "prefer-const": "error",
+          "no-empty": "warn",
           "no-undef": "off",
-          "no-useless-catch": "off",
+          "no-useless-catch": "error",
           "@typescript-eslint/no-this-alias": "off",
           "@typescript-eslint/no-unsafe-function-type": "off"
       }

packages/drivers/memory/src/index.ts

@@ -345,7 +345,7 @@ export class MemoryDriver implements Driver {
         }
 
         // Get all records for this object type
-        let records: any[] = [];
+        const records: any[] = [];
         for (const [key, value] of this.store.entries()) {
             if (key.startsWith(pattern)) {
                 records.push(value);
@@ -422,7 +422,7 @@ export class MemoryDriver implements Driver {
         const pattern = `${objectName}:`;
 
         // Get all records for this object type
-        let records: any[] = [];
+        const records: any[] = [];
         const recordKeys = new Map<string, string>();
 
         for (const [key, record] of this.store.entries()) {
@@ -468,7 +468,7 @@ export class MemoryDriver implements Driver {
         const pattern = `${objectName}:`;
 
         // Get all records for this object type
-        let records: any[] = [];
+        const records: any[] = [];
         const recordKeys = new Map<string, string>();
 
         for (const [key, record] of this.store.entries()) {
@@ -554,7 +554,7 @@ export class MemoryDriver implements Driver {
         const pattern = `${objectName}:`;
 
         // Get all records for this object type
-        let records: any[] = [];
+        const records: any[] = [];
         for (const [key, value] of this.store.entries()) {
             if (key.startsWith(pattern)) {
                 records.push({ ...value });

packages/drivers/redis/src/index.ts

@@ -1175,8 +1175,8 @@ export class RedisDriver implements Driver {
             return true;
         }
 
-        let conditions: boolean[] = [];
-        let operators: string[] = [];
+        const conditions: boolean[] = [];
+        const operators: string[] = [];
 
         for (const item of filters) {
             if (typeof item === 'string') {

packages/drivers/sql/src/index.ts

@@ -139,9 +139,9 @@ export class SqlDriver implements Driver {
                      const field = this.mapSortField(fieldRaw);
                      // Handle specific operators that map to different knex methods
                      const apply = (b: any) => {
-                         let method = nextJoin === 'or' ? 'orWhere' : 'where';
-                         let methodIn = nextJoin === 'or' ? 'orWhereIn' : 'whereIn';
-                         let methodNotIn = nextJoin === 'or' ? 'orWhereNotIn' : 'whereNotIn';
+                         const method = nextJoin === 'or' ? 'orWhere' : 'where';
+                         const methodIn = nextJoin === 'or' ? 'orWhereIn' : 'whereIn';
+                         const methodNotIn = nextJoin === 'or' ? 'orWhereNotIn' : 'whereNotIn';
 
                          // Fix for 'contains' mapping
                          if (op === 'contains') {
@@ -857,7 +857,7 @@ export class SqlDriver implements Driver {
         const config = this.config;
         const connection = config.connection;
         let dbName = '';
-        let adminConfig = { ...config };
+        const adminConfig = { ...config };
 
         if (typeof connection === 'string') {
             const url = new URL(connection);
@@ -872,8 +872,6 @@ export class SqlDriver implements Driver {
         const adminKnex = knex(adminConfig);
         try {
             await adminKnex.raw(`CREATE DATABASE "${dbName}"`);
-        } catch (e: any) {
-             throw e;
         } finally {
             await adminKnex.destroy();
         }

packages/foundation/core/src/app.ts

@@ -286,12 +286,7 @@ export class ObjectQL implements IObjectQL {
                       return callback(ctx);
                  }
 
-                 let trx: any;
-                 try {
-                     trx = await driver.beginTransaction();
-                 } catch (e) {
-                     throw e;
-                 }
+                 const trx: any = await driver.beginTransaction();
 
                  const trxCtx: ObjectQLContext = {
                      ...ctx,

packages/foundation/platform-node/src/module.ts

@@ -49,7 +49,7 @@ export async function loadModules(loader: ObjectLoader, modules: string[]) {
                             packageRoot = currentDir;
                             break;
                         }
-                    } catch (e) {}
+                    } catch (_e) { /* package.json parse error — skip directory */ }
                 }
                 currentDir = path.dirname(currentDir);
             }

packages/foundation/plugin-workflow/__tests__/state-machine-engine.spec.ts

@@ -313,7 +313,7 @@ describe('StateMachineEngine', () => {
       const engine = new StateMachineEngine(config, guardEvaluator, actionExecutor);
 
       // Transition within compound state using absolute path
-      let result = await engine.transition('editing.draft', 'editing.review', {
+      const result = await engine.transition('editing.draft', 'editing.review', {
         record: { status: 'editing.draft' },
         operation: 'update',
       });

packages/protocols/graphql/src/index.ts

@@ -1115,7 +1115,7 @@ export class GraphQLPlugin implements RuntimePlugin {
                 }
 
                 // Handle cursor-based pagination
-                let limit = args.first || args.last || 20;
+                const limit = args.first || args.last || 20;
                 let offset = 0;
 
                 if (args.after) {

packages/tools/create/src/bin.ts

@@ -98,7 +98,7 @@ program
     // 5. Initialize Git
     try {
         await fs.writeFile(path.join(root, '.gitignore'), `node_modules/\ndist/\n*.log\n.DS_Store\n*.sqlite3\n.env\n.env.local\n`);
-    } catch {}
+    } catch (_e) { /* .gitignore write failure is non-critical */ }
 
     console.log(chalk.green('\n✅ Done! Now run:\n'));
     console.log(chalk.cyan(`  cd ${targetDir}`));

packages/tools/vscode-objectql/src/commands/createFile.ts

@@ -93,7 +93,7 @@ export async function createNewFile(
 function getTemplate(context: vscode.ExtensionContext, fileType: string, name: string): string {
     try {
       // Look for templates in the 'templates' folder at the root of the extension
-      let templatePath = vscode.Uri.joinPath(context.extensionUri, 'templates', `${fileType}.template.yml`).fsPath;
+      const templatePath = vscode.Uri.joinPath(context.extensionUri, 'templates', `${fileType}.template.yml`).fsPath;
 
       if (fs.existsSync(templatePath)) {
           let content = fs.readFileSync(templatePath, 'utf8');