Merge pull request #362 from objectstack-ai/copilot/fix-ci-build-and-test

hotlong · web-flow · commit b9b7a27eff13 · 2026-02-10T08:47:06.000+08:00
diff --git a/packages/drivers/sdk/src/index.ts b/packages/drivers/sdk/src/index.ts
@@ -545,19 +545,19 @@ export class RemoteDriver implements Driver {
      * @example
      * ```typescript
      * // Execute a custom workflow
-     * const result = await driver.execute('/api/workflows/approve', {
+     * const result = await driver.executeCustomEndpoint('/api/workflows/approve', {
      *   workflowId: 'wf_123',
      *   comment: 'Approved'
      * });
      * 
      * // Use default execute endpoint
-     * const result = await driver.execute(undefined, {
+     * const result = await driver.executeCustomEndpoint(undefined, {
      *   action: 'calculateMetrics',
      *   params: { year: 2024 }
      * });
      * ```
      */
-    async execute(endpoint?: string, payload?: any, _options?: any): Promise<any> {
+    async executeCustomEndpoint(endpoint?: string, payload?: any, _options?: any): Promise<any> {
         return this.retryWithBackoff(async () => {
             const targetEndpoint = endpoint 
                 ? this.buildEndpoint(endpoint)
diff --git a/packages/drivers/sdk/test/remote-driver.test.ts b/packages/drivers/sdk/test/remote-driver.test.ts
@@ -688,7 +688,7 @@ describe('RemoteDriver', () => {
                 json: async () => mockResponse
             });
 
-            const result = await driver.execute('/api/custom', payload);
+            const result = await driver.executeCustomEndpoint('/api/custom', payload);
 
             expect(global.fetch).toHaveBeenCalledWith(
                 'http://localhost:3000/api/custom',
@@ -708,7 +708,7 @@ describe('RemoteDriver', () => {
                 json: async () => ({ success: true })
             });
 
-            await driver.execute(undefined, payload);
+            await driver.executeCustomEndpoint(undefined, payload);
 
             expect(global.fetch).toHaveBeenCalledWith(
                 'http://localhost:3000/api/execute',
@@ -729,7 +729,7 @@ describe('RemoteDriver', () => {
                 })
             });
 
-            await expect(driver.execute('/api/test', {}))
+            await expect(driver.executeCustomEndpoint('/api/test', {}))
                 .rejects
                 .toThrow('Server error');
         });
diff --git a/packages/foundation/core/src/query/query-analyzer.ts b/packages/foundation/core/src/query/query-analyzer.ts
@@ -271,7 +271,7 @@ export class QueryAnalyzer {
      * @private
      */
     private getSchema(objectName: string): ObjectConfig {
-        const obj = this.metadata.get('object', objectName);
+        const obj = this.metadata.get<ObjectConfig>('object', objectName);
         if (!obj) {
             throw new ObjectQLError({ code: 'NOT_FOUND', message: `Object '${objectName}' not found` });
         }
diff --git a/packages/foundation/core/src/query/query-service.ts b/packages/foundation/core/src/query/query-service.ts
@@ -132,7 +132,7 @@ export class QueryService {
      * @private
      */
     private getSchema(objectName: string): ObjectConfig {
-        const obj = this.metadata.get('object', objectName);
+        const obj = this.metadata.get<ObjectConfig>('object', objectName);
         if (!obj) {
             throw new ObjectQLError({ code: 'NOT_FOUND', message: `Object '${objectName}' not found in metadata` });
         }
diff --git a/packages/foundation/core/src/repository.ts b/packages/foundation/core/src/repository.ts
@@ -28,7 +28,7 @@ export class ObjectRepository {
     }
     
     private getKernel(): ObjectKernel {
-        return this.app.getKernel();
+        return this.app.getKernel() as ObjectKernel;
     }
 
     private getOptions(extra: Record<string, unknown> = {}) {
diff --git a/packages/foundation/platform-node/src/loader.ts b/packages/foundation/platform-node/src/loader.ts
@@ -44,7 +44,7 @@ export class ObjectLoader {
                             // Object name does not match filename — using doc.name
                         }
 
-                        const packageEntry = ctx.registry.getEntry('package-map', ctx.file);
+                        const packageEntry = ctx.registry.getEntry<{ package?: string }>('package-map', ctx.file);
                         registerObject(ctx.registry, doc, ctx.file, ctx.packageName || (packageEntry && packageEntry.package));
                         return;
                     }
@@ -295,7 +295,7 @@ function registerObject(registry: MetadataRegistry, obj: any, file: string, pack
     // --- End Smart Defaults ---
 
     // Check for existing object to Merge
-    const existing = registry.getEntry('object', obj.name);
+    const existing = registry.getEntry<{ content?: ObjectConfig }>('object', obj.name);
     if (existing) {
         const base = existing.content as ObjectConfig;
         
diff --git a/packages/foundation/plugin-security/src/storage-database.ts b/packages/foundation/plugin-security/src/storage-database.ts
@@ -22,6 +22,17 @@ import type { IPermissionStorage, SecurityPluginConfig } from './types';
 /** Default table name for storing permission metadata */
 const DEFAULT_TABLE = 'objectql_permissions';
 
+/**
+ * Interface for permission storage row structure
+ */
+interface PermissionRow {
+  _id?: string | number;
+  id?: string | number;
+  object_name: string;
+  config: string;
+  updated_at?: string;
+}
+
 /**
  * Resolver function that locates a Driver instance by datasource name.
  * Typically wired from the ObjectQL application layer.
@@ -118,7 +129,7 @@ export class DatabasePermissionStorage implements IPermissionStorage {
         filters: [['object_name', '=', objectName]],
         top: 1,
       });
-      const row = Array.isArray(rows) ? rows[0] : undefined;
+      const row = Array.isArray(rows) ? rows[0] as unknown as PermissionRow | undefined : undefined;
       if (!row) return undefined;
       return JSON.parse(row.config) as PermissionConfig;
     } catch {
@@ -131,7 +142,7 @@ export class DatabasePermissionStorage implements IPermissionStorage {
     const result = new Map<string, PermissionConfig>();
     try {
       const rows = await driver.find(this.tableName, {});
-      const items = Array.isArray(rows) ? rows : [];
+      const items = Array.isArray(rows) ? rows as unknown as PermissionRow[] : [];
       for (const row of items) {
         try {
           const config = JSON.parse(row.config) as PermissionConfig;
@@ -152,10 +163,11 @@ export class DatabasePermissionStorage implements IPermissionStorage {
     try {
       const rows = await driver.find(this.tableName, {});
       // Create a shallow copy to avoid issues when deleting during iteration
-      const items = Array.isArray(rows) ? [...rows] : [];
+      const items = Array.isArray(rows) ? rows as unknown as PermissionRow[] : [];
       for (const row of items) {
-        if (row._id || row.id || row.object_name) {
-          await driver.delete(this.tableName, row._id ?? row.id ?? row.object_name, {});
+        const id = row._id ?? row.id ?? row.object_name;
+        if (id !== undefined) {
+          await driver.delete(this.tableName, id, {});
         }
       }
     } catch {
@@ -185,13 +197,15 @@ export class DatabasePermissionStorage implements IPermissionStorage {
         filters: [['object_name', '=', config.object]],
         top: 1,
       });
-      const row = Array.isArray(rows) ? rows[0] : undefined;
+      const row = Array.isArray(rows) ? rows[0] as unknown as PermissionRow | undefined : undefined;
       if (row) {
         const id = row._id ?? row.id ?? row.object_name;
-        await driver.update(this.tableName, id, {
+        if (id !== undefined) {
+          await driver.update(this.tableName, id, {
           config: JSON.stringify(config),
           updated_at: new Date().toISOString(),
         }, {});
+        }
       }
     } else {
       await driver.create(this.tableName, {
@@ -212,10 +226,12 @@ export class DatabasePermissionStorage implements IPermissionStorage {
         filters: [['object_name', '=', objectName]],
         top: 1,
       });
-      const row = Array.isArray(rows) ? rows[0] : undefined;
+      const row = Array.isArray(rows) ? rows[0] as unknown as PermissionRow | undefined : undefined;
       if (row) {
         const id = row._id ?? row.id ?? row.object_name;
-        await driver.delete(this.tableName, id, {});
+        if (id !== undefined) {
+          await driver.delete(this.tableName, id, {});
+        }
       }
     } catch {
       // Row may not exist
diff --git a/packages/foundation/plugin-validator/src/validator.ts b/packages/foundation/plugin-validator/src/validator.ts
@@ -27,6 +27,13 @@ import {
     ValidationOperator,
 } from '@objectql/types';
 
+/**
+ * Minimal API interface expected by validation context
+ */
+interface ValidationApi {
+    count(objectName: string, filters: Record<string, unknown>): Promise<number>;
+}
+
 /**
  * Configuration options for the Validator.
  */
@@ -364,7 +371,7 @@ export class Validator {
         }
 
         // Check if transition is allowed
-        const transitions = rule.transitions?.[oldState];
+        const transitions = rule.transitions?.[oldState as string];
         if (!transitions) {
             return {
                 rule: rule.name,
@@ -384,7 +391,7 @@ export class Validator {
             allowedNext = transitions.allowed_next || [];
         }
 
-        const isAllowed = allowedNext.includes(newState);
+        const isAllowed = allowedNext.includes(newState as string);
 
         return {
             rule: rule.name,
@@ -480,7 +487,7 @@ export class Validator {
 
         try {
             // Query database to count existing records with same field values
-            const count = await context.api.count(objectName, filters);
+            const count = await (context.api as ValidationApi).count(objectName, filters);
 
             const valid = count === 0;
 
diff --git a/packages/foundation/plugin-workflow/__tests__/workflow-plugin.spec.ts b/packages/foundation/plugin-workflow/__tests__/workflow-plugin.spec.ts
@@ -8,7 +8,7 @@
 
 import { describe, it, expect, beforeEach } from 'vitest';
 import { WorkflowPlugin } from '../src/workflow-plugin';
-import type { _StateMachineConfig } from '@objectql/types';
+import type { StateMachineConfig } from '@objectql/types';
 
 describe('WorkflowPlugin', () => {
   let plugin: WorkflowPlugin;
diff --git a/packages/foundation/plugin-workflow/src/types.ts b/packages/foundation/plugin-workflow/src/types.ts
@@ -11,7 +11,7 @@
  * These complement the protocol types from @objectql/types
  */
 
-import type { _StateMachineConfig } from '@objectql/types';
+import type { StateMachineConfig } from '@objectql/types';
 
 /**
  * Execution context for state machine operations
diff --git a/packages/tools/cli/src/commands/repl.ts b/packages/tools/cli/src/commands/repl.ts
@@ -73,7 +73,7 @@ export async function startRepl(configPath?: string) {
         r.context.object = (name: string) => app.getObject(name);
         
         // Helper to get a repo quickly: tasks.find() instead of app.object('tasks').find()
-        const objects = app.metadata.list('object');
+        const objects = app.metadata.list<{ name: string }>('object');
         for (const obj of objects) {
             // Inject repositories as top-level globals if valid identifiers
             if (/^[a-zA-Z_$][a-zA-Z0-9_$]*$/.test(obj.name)) {

Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,7 @@ export class QueryAnalyzer {`
`271`	`271`	`* @private`
`272`	`272`	`*/`
`273`	`273`	`private getSchema(objectName: string): ObjectConfig {`
`274`		`- const obj = this.metadata.get('object', objectName);`
	`274`	`+ const obj = this.metadata.get<ObjectConfig>('object', objectName);`
`275`	`275`	`if (!obj) {`
`276`	`276`	throw new ObjectQLError({ code: 'NOT_FOUND', message: `Object '${objectName}' not found` });
`277`	`277`	`}`
Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ export class QueryService {`
`132`	`132`	`* @private`
`133`	`133`	`*/`
`134`	`134`	`private getSchema(objectName: string): ObjectConfig {`
`135`		`- const obj = this.metadata.get('object', objectName);`
	`135`	`+ const obj = this.metadata.get<ObjectConfig>('object', objectName);`
`136`	`136`	`if (!obj) {`
`137`	`137`	throw new ObjectQLError({ code: 'NOT_FOUND', message: `Object '${objectName}' not found in metadata` });
`138`	`138`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ export class ObjectRepository {`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`private getKernel(): ObjectKernel {`
`31`		`- return this.app.getKernel();`
	`31`	`+ return this.app.getKernel() as ObjectKernel;`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`private getOptions(extra: Record<string, unknown> = {}) {`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ export class ObjectLoader {`
`44`	`44`	`// Object name does not match filename — using doc.name`
`45`	`45`	`}`
`46`	`46`
`47`		`- const packageEntry = ctx.registry.getEntry('package-map', ctx.file);`
	`47`	`+ const packageEntry = ctx.registry.getEntry<{ package?: string }>('package-map', ctx.file);`
`48`	`48`	`registerObject(ctx.registry, doc, ctx.file, ctx.packageName \|\| (packageEntry && packageEntry.package));`
`49`	`49`	`return;`
`50`	`50`	`}`
`@@ -295,7 +295,7 @@ function registerObject(registry: MetadataRegistry, obj: any, file: string, pack`
`295`	`295`	`// --- End Smart Defaults ---`
`296`	`296`
`297`	`297`	`// Check for existing object to Merge`
`298`		`- const existing = registry.getEntry('object', obj.name);`
	`298`	`+ const existing = registry.getEntry<{ content?: ObjectConfig }>('object', obj.name);`
`299`	`299`	`if (existing) {`
`300`	`300`	`const base = existing.content as ObjectConfig;`
`301`	`301`