Address code review feedback: improve type safety and error messages

Co-authored-by: huangyiirene <7665279+huangyiirene@users.noreply.github.com>

Author: Copilot

packages/foundation/core/src/app.ts

@@ -221,7 +221,7 @@ export class ObjectQL implements IObjectQL {
      * 
      * @private
      */
-    private createPluginContext(app: IObjectQL): any {
+    private createPluginContext(app: IObjectQL): import('@objectstack/spec').PluginContextData {
         // TODO: Implement full PluginContext conversion
         // For now, provide a minimal adapter that maps IObjectQL to PluginContext
         return {
@@ -233,7 +233,12 @@ export class ObjectQL implements IObjectQL {
                 },
                 query: async (soql: string) => {
                     // TODO: Implement SOQL query execution
-                    throw new Error('SOQL queries not yet implemented in adapter');
+                    // This requires implementing a SOQL parser and converter
+                    // For now, throw a descriptive error to guide users
+                    throw new Error(
+                        'SOQL queries are not yet supported in plugin context adapter. ' +
+                        'Please use context.ql.object(name).find() instead for data access.'
+                    );
                 }
             },
             os: {
@@ -274,13 +279,13 @@ export class ObjectQL implements IObjectQL {
             },
             app: {
                 router: {
-                    get: (path: string, handler: Function) => {
+                    get: (path: string, handler: (...args: unknown[]) => unknown, ...args: unknown[]) => {
                         // TODO: Implement router registration
                     },
-                    post: (path: string, handler: Function) => {
+                    post: (path: string, handler: (...args: unknown[]) => unknown, ...args: unknown[]) => {
                         // TODO: Implement router registration
                     },
-                    use: (pathOrHandler: string | Function, handler?: Function) => {
+                    use: (path: string | undefined, handler: (...args: unknown[]) => unknown, ...args: unknown[]) => {
                         // TODO: Implement middleware registration
                     }
                 },

packages/foundation/platform-node/src/plugin.ts

@@ -25,11 +25,16 @@ export function loadPlugin(packageName: string): ObjectQLPlugin | PluginDefiniti
     // Helper to check if candidate is a new PluginDefinition
     const isNewPlugin = (candidate: any): candidate is PluginDefinition => {
         return candidate && (
+            // Check for any lifecycle method
             typeof candidate.onEnable === 'function' ||
             typeof candidate.onDisable === 'function' ||
             typeof candidate.onInstall === 'function' ||
             typeof candidate.onUninstall === 'function' ||
             typeof candidate.onUpgrade === 'function'
+        ) && (
+            // Note: id is optional in PluginDefinition, so we don't require it
+            // The spec allows plugins without id (it just defaults to package name)
+            candidate.id === undefined || typeof candidate.id === 'string'
         );
     };