Repository navigation
Commit ebfadb0
chore(ui): remove the vscode-extension package from the monorepo (#27275)
domain:devx#2 · os-justin · session_01QSeKYmTYfaPbLQD4BJfomW
Fixes #25910
Clause-②: no
Metadata-protocol: none
Ruling-ref: 6386223367
## 维护者速读
- 改了什么:按裁决 B(移出)从单仓删除 `ui/packages/vscode-extension/`(25
个文件),并清掉所有引用它的读者:文档页与导航、CONTRIBUTING 两行、changeset
固定组成员、各门禁的豁免条目与钉住它的测试;`pnpm-lock.yaml` 用 `pnpm install` 重新生成。
- 为什么改:这个扩展号称「official」,却没有构建、没有发布、没有门禁,坏了也没人知道;维护者裁定移出,历史保留在 git 里。
- 风险与回滚:只删一个 private、无人依赖的包,不改任何已发布包的行为;回滚就是 revert 本 PR。改动行数超过
3,000(主要是删除的文件和锁文件),按规则须经授权批准或维护者亲手合并。
- 先看:`.changeset/config.json` 与
`scripts/check-changeset-fixed.mjs`(固定组成员删除与 `PRIVATE_FIXED_MEMBERS`
清空);`ui/scripts/__tests__/check-doc-links.test.ts`(三个下限按实测下调,各自写明原因);`ui/scripts/check-unused-dependencies.mjs`(删掉扩展的两条豁免)。
- 两分钟验证:`node scripts/check-changeset-fixed.mjs`,预期输出 `✓
.changeset/config.json "fixed" group is in sync with 109 public
workspace packages.`
- 需要你做的:批准或亲手合并(改动行数超过 3,000 的 PR 不能由席位自动落地)。
## What changes
- **Deleted** `ui/packages/vscode-extension/` (25 files) and its docs
page `ui/content/docs/utilities/vscode-extension.mdx`. The page also
comes out of `utilities/meta.json`, three spots in `utilities/index.md`,
and `guide/architecture.md`.
- **Root:** two `CONTRIBUTING.md` rows; the `object-ui` member of the
`.changeset/config.json` `fixed` group; and `PRIVATE_FIXED_MEMBERS` in
`scripts/check-changeset-fixed.mjs`, now empty with a rewritten comment.
The mechanism stays and is still fixture-tested.
- **`pnpm-lock.yaml`:** regenerated with `pnpm install` on the tree,
then again verified with `--frozen-lockfile` after merging
`origin/main`.
- **ui gates and their tests:**
- `check-unused-dependencies.mjs`: the extension's two bundler-inlined
allowances go, together with the now-unused `bundlerInlinedAllowance`
helper. The gate's own rule 3 reds a row with no subject.
- `markdown-test-inputs.mjs`: the extension test's ledger entry goes.
- `body-dialect-census.test.ts`: the three deleted reader/producer paths
leave their lists, following the runner precedent beside them. The
`CompletionProvider` by-name pin is replaced with a note. The population
zero and both of its lit controls stay.
- `check-changeset-fixed.test.ts`: the "still keeps the private VS Code
extension inside the fixed group" pin becomes "puts no private package
inside the fixed group", the shape that is true now.
- `check-doc-snippet-emitted-census.test.ts`: the per-package split test
moves to a neutral fixture. The repository test keeps its remaining
named member and its `>= 2` floor.
- `check-doc-component-types.test.ts`: the deleted page leaves the
`heading` list.
- **Measured floors and counts,** each with its reason in the comment:
- `check-doc-links.test.ts`: `packages/*` docs 11 → 8 and combined 14 →
11 (the package's `DESIGN.md`, `ICON.md` and `PUBLISHING.md`); README
decidable hrefs 135 → 126 and site-absolute 40 → 39 (this card's
extension README, plus #27042's plugin-ai README on the merge with
main); `content/docs` site-absolute 6 → 5 (the deleted page);
package-dir decidable 2 → 1 (`DESIGN.md`).
- `ui/tsconfig.json` / `ui/tsconfig.tier-base.json`: the `extends` graph
re-measured with `ts.readConfigFile` at 87 tracked files, 73 of them
extending the root (37/38 package `tsconfig.json` and all 35
`tsconfig.test.json`). `packages/runner` is now the only one that
extends nothing.
- **Comments only:** present-tense claims about the extension in
`@object-ui/core` (`dataset-format.ts`, `number-display.ts`),
`@object-ui/types` (`form.zod.ts`, `package-exports-manifest.test.ts`)
and eight `ui/scripts` files are past-tensed. Historical notes, released
`CHANGELOG.md` entries and dated `ui/docs/audits/*` are untouched.
## Tests
Read on the merged head `383f0f0a` (merge of `origin/main` `1c5fe3cb`).
- `pnpm --dir ui exec vitest run --maxWorkers=2 scripts/` (lock VERDICT
command-exit 1): Test Files 16 failed / 158 passed, Tests 57 failed /
4659 passed. **That failing set is identical to the untouched baseline
at `4d3a077f` (57 failed). This diff adds 0 failures.** All 57 are
pre-existing environment failures: the unbuilt `@objectstack/spec`
`dist` that ratchets and ledgers import (`spec-symbol-ledger-*`,
`check-doc-expression-carriage`, `date-only-zone-pins` …).
- Before the reader fixes, the deletion alone added 10 failures to that
baseline. All 10 are green now.
## Acceptance notes
- Changed lines are 8,704 (+170 / −8,534), almost all deleted files and
the lockfile. That is over the 3,000-line threshold, so this PR lands by
an authorized approval or the maintainer's own merge.
- Lowered floors: every one moves down by exactly the content this
ruling deletes, with the measured value and its reason in the comment
beside it. None is loosened beyond that.
- The `vscode` row in `HOST_PROVIDED`
(`ui/scripts/check-phantom-dependencies.mjs`) stays. It is
fixture-tested and generic, and only its comment changed.
- Left alone on purpose:
- `ui/packages/plugin-ai/tsconfig.test.json` L42: open PR #27042 retires
that package.
- `skills/objectui/README.md` L59: `skills/**` is out of scope here and
is forwarded by the seat.
- Synthetic fixture paths in `body-dialect-producer-scan.test.ts`.
- The ruling's "`ci.yml` comment" has 0 hits on `main`, so there was
nothing to edit under `.github/workflows/**`.
## Verification
<details><summary>Derived gates (dispatch-gates --commands, 75 commands
at 383f0f0)</summary>
- 73 non-suite commands run, each exit captured before any pipe:
- 69 exit 0.
- 4 exit 3 (PREREQUISITE NOT MET: `pnpm build` not run, so nothing was
measured): `check:dts-closure`, `check:dual-build-cjs-loads`,
`check:lean-entry-closure`, `check:sourcemap-no-sources-content`. All
four read built `@objectstack/*` dists this diff does not touch. NOT
MEASURED locally; CI's Build Core / Lint run them.
- `pnpm --dir ui exec vitest run scripts/`: see Tests.
- `pnpm check:pm-dispatch-gates`: see the report.
- Also run:
- `node scripts/check-changeset-fixed.mjs --self-test`: 12 cases pass.
- `node scripts/check-changeset-fixed.mjs`: in sync with 109 public
packages.
- `ui`'s `check-changeset-fixed`, `check-doc-links` (13 scan roots),
`check-doc-component-types`, `check-unused-dependencies` and
`check-phantom-dependencies`: all exit 0.
- `pnpm install --frozen-lockfile`: exit 0.
</details>
---
_Generated by [Claude
Code](https://claude.ai/code/session_01QSeKYm29SiQaonK2q8F7CS)_
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 0dd93f2 commit ebfadb0
58 files changed
Lines changed: 173 additions & 8535 deletions
File tree
- .changeset
- scripts
- ui
- content/docs
- guide
- utilities
- packages
- core/src/utils
- types/src
- __tests__
- zod
- vscode-extension
- schemas
- snippets
- src
- __tests__
- providers
- syntaxes
- scripts
- __tests__
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
118 | | - | |
119 | | - | |
| 118 | + | |
120 | 119 | | |
121 | 120 | | |
122 | 121 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
288 | 288 | | |
289 | 289 | | |
290 | 290 | | |
291 | | - | |
| 291 | + | |
292 | 292 | | |
293 | 293 | | |
294 | 294 | | |
| |||
513 | 513 | | |
514 | 514 | | |
515 | 515 | | |
516 | | - | |
517 | 516 | | |
518 | 517 | | |
519 | 518 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
44 | 42 | | |
45 | 43 | | |
46 | 44 | | |
47 | | - | |
48 | | - | |
49 | | - | |
| 45 | + | |
50 | 46 | | |
51 | 47 | | |
52 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
111 | 110 | | |
112 | 111 | | |
113 | 112 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | 24 | | |
29 | 25 | | |
30 | 26 | | |
| |||
98 | 94 | | |
99 | 95 | | |
100 | 96 | | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | 97 | | |
122 | 98 | | |
123 | 99 | | |
| |||
212 | 188 | | |
213 | 189 | | |
214 | 190 | | |
215 | | - | |
216 | 191 | | |
217 | 192 | | |
218 | 193 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
| 6 | + | |
8 | 7 | | |
9 | 8 | | |
0 commit comments