Collapse NamespaceDirectory::createFromClass() into ::fromClass().

Author: donquixote

src/ClassFilesIA/ClassFilesIA.php

@@ -42,7 +42,7 @@ public static function psr4Up(string $directory, string $namespace, int $nLevels
    * @return \Ock\ClassFilesIterator\NamespaceDirectory
    */
   public static function psr4FromClass(string $class, int $nLevelsUp = 0): NamespaceDirectory {
-    $result = NamespaceDirectory::createFromClass($class);
+    $result = NamespaceDirectory::fromClass($class);
     if ($nLevelsUp !== 0) {
       $result = $result->requireParentN($nLevelsUp);
     }

src/ClassFilesIA/ClassFilesIA_Psr4.php

@@ -36,7 +36,7 @@ public static function create(string $directory, string $namespace): self {
    * @return \Ock\ClassFilesIterator\ClassFilesIA\ClassFilesIAInterface
    */
   public static function createFromClass(string $class, int $nLevelsUp = 0): ClassFilesIAInterface {
-    $nsDir = NamespaceDirectory::createFromClass($class)
+    $nsDir = NamespaceDirectory::fromClass($class)
       ->requireParentN($nLevelsUp);
     return self::createFromNsdirObject($nsDir);
   }

src/NamespaceDirectory.php

@@ -42,28 +42,12 @@ public static function create(string $directory, string $namespace): self {
    * Creates a namespace directory based on a known class name.
    *
    * @param class-string $class
-   *
-   * @return self
-   */
-  public static function fromClass(string $class): self {
-    try {
-      return self::createFromClass($class);
-    }
-    catch (\ReflectionException $e) {
-      throw new \RuntimeException($e->getMessage(), 0, $e);
-    }
-  }
-
-  /**
-   * Creates a namespace directory based on a class name.
-   *
-   * @param class-string $class
    *   A class in the namespace directory.
    *
    * @return self
-   *   Namespace directory of this very class file.
+   *   Namespace directory which contains the given class.
    */
-  public static function createFromClass(string $class): self {
+  public static function fromClass(string $class): self {
     try {
       $reflClass = new \ReflectionClass($class);
     }

tests/src/NamespaceDirectoryTest.php

@@ -50,26 +50,7 @@ public function testFromClass(): void {
     // Does not work with built-in class.
     $this->callAndAssertException(
       \InvalidArgumentException::class,
-      fn() => NamespaceDirectory::fromClass(\stdClass::class),
-    );
-  }
-
-  public function testCreateFromClass(): void {
-    $this->assertNamespaceDir(
-      __DIR__,
-      __NAMESPACE__,
-      NamespaceDirectory::createFromClass(self::class),
-    );
-    // Does not work with non-existing class.
-    $this->callAndAssertException(
-      \RuntimeException::class,
-      // @phpstan-ignore argument.type
-      fn () => NamespaceDirectory::createFromClass(__NAMESPACE__ . '\\NonExistingClass'),
-    );
-    // Does not work with built-in class.
-    $this->callAndAssertException(
-      \InvalidArgumentException::class,
-      fn () => NamespaceDirectory::createFromClass(\stdClass::class),
+      fn () => NamespaceDirectory::fromClass(\stdClass::class),
     );
   }