fix: add --log-format=%i to daemon args for itemize interop (#3083)

Upstream options.c:2750-2762 sends --log-format=%i to the server when
the client is sender (push mode) and itemize-changes is enabled. This
tells the daemon's receiver to emit itemize output via MSG_INFO frames.

The SSH invocation path already included this arg, but the daemon
argument builder (build_full_daemon_args) was missing it, causing
oc:itemize interop test failures when pushing to an upstream daemon.

Also removes oc:itemize and oc:merge-filter from KNOWN_FAILURES.

Author: oferchen

crates/core/src/client/remote/daemon_transfer/orchestration/arguments.rs

@@ -158,6 +158,13 @@ pub(super) fn build_full_daemon_args(
     // --- Long-form arguments (upstream server_options() options.c:2737-2980) ---
     let we_are_sender = !is_sender;
 
+    // upstream: options.c:2750-2762 - server needs to know about log-format
+    // so it can generate itemize output via MSG_INFO frames.
+    // Only sent when client is sender (push) - matches upstream am_sender guard.
+    if we_are_sender && config.itemize_changes() {
+        args.push("--log-format=%i".to_owned());
+    }
+
     // --compress-level=N
     // upstream: options.c:2737-2740
     if let Some(level) = config.compression_level() {

crates/core/src/client/remote/daemon_transfer/orchestration/tests.rs

@@ -173,6 +173,51 @@ mod protect_args_daemon_tests {
             "pull mode should not send reference dir args to daemon: {args:?}"
         );
     }
+
+    #[test]
+    fn build_full_args_includes_log_format_for_itemize_push() {
+        // upstream: options.c:2750-2762 - --log-format=%i sent when am_sender
+        // (client is sender / push mode) so daemon receiver emits itemize via MSG_INFO.
+        let config = ClientConfig::builder().itemize_changes(true).build();
+        let request = test_daemon_request();
+        let protocol = ProtocolVersion::try_from(32u8).unwrap();
+        // is_sender=false means daemon is NOT sender, i.e., client IS sender (push)
+        let args = build_full_daemon_args(&config, &request, protocol, false);
+
+        assert!(
+            args.iter().any(|a| a == "--log-format=%i"),
+            "push with itemize should include --log-format=%i: {args:?}"
+        );
+    }
+
+    #[test]
+    fn build_full_args_omits_log_format_for_itemize_pull() {
+        // upstream: options.c:2752 - --log-format only sent when am_sender.
+        // In pull mode (daemon is sender), client handles itemize locally.
+        let config = ClientConfig::builder().itemize_changes(true).build();
+        let request = test_daemon_request();
+        let protocol = ProtocolVersion::try_from(32u8).unwrap();
+        // is_sender=true means daemon IS sender (pull)
+        let args = build_full_daemon_args(&config, &request, protocol, true);
+
+        assert!(
+            !args.iter().any(|a| a == "--log-format=%i"),
+            "pull with itemize should not include --log-format=%i: {args:?}"
+        );
+    }
+
+    #[test]
+    fn build_full_args_omits_log_format_without_itemize() {
+        let config = ClientConfig::default();
+        let request = test_daemon_request();
+        let protocol = ProtocolVersion::try_from(32u8).unwrap();
+        let args = build_full_daemon_args(&config, &request, protocol, false);
+
+        assert!(
+            !args.iter().any(|a| a.starts_with("--log-format")),
+            "should not include --log-format without itemize: {args:?}"
+        );
+    }
 }
 
 mod server_config_reference_dirs {

tools/ci/run_interop.sh

@@ -1502,7 +1502,6 @@ KNOWN_FAILURES=(
   "oc:acls"
   "oc:xattrs"
   "oc:compress-lz4"
-  "oc:itemize"
   # --- upstream→oc (daemon receive) ---
   "up:acls"
   "up:xattrs"