From f8b3f2bb26be806dff598e3da4936329c010f41e Mon Sep 17 00:00:00 2001 From: Shavonn Brown Date: Fri, 3 Jul 2026 17:58:57 -0400 Subject: [PATCH 1/3] fix: project imports in resource filters --- src/components/composite/resource-filters.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/components/composite/resource-filters.tsx b/src/components/composite/resource-filters.tsx index 8af763c..152b39b 100644 --- a/src/components/composite/resource-filters.tsx +++ b/src/components/composite/resource-filters.tsx @@ -1,9 +1,10 @@ -import { SearchField, SearchInput } from "@offload-project/hallogen/search-field"; -import { Toolbar, ToolbarLeft, ToolbarRight } from "@offload-project/hallogen/toolbar"; import type { ReactNode, SubmitEvent } from "react"; import type { Key } from "react-aria-components"; +import { SearchField } from "react-aria-components/SearchField"; import { ResourceClearFilters } from "@/components/composite/resource-clear-filters"; +import { SearchInput } from "@/components/ui/search-field.tsx"; import { TableColumnMenu } from "@/components/ui/table.tsx"; +import { Toolbar, ToolbarLeft, ToolbarRight } from "@/components/ui/toolbar.tsx"; import type { ColumnDef } from "@/types"; interface Props { From 377860b04a1284b6e39b73dbf836a976f9c59b64 Mon Sep 17 00:00:00 2001 From: Shavonn Brown Date: Fri, 3 Jul 2026 21:07:32 -0400 Subject: [PATCH 2/3] test: accessibility test failures --- src/components/ui/choice-box.tsx | 2 +- src/components/ui/dropdown.tsx | 2 +- src/components/ui/tracker.tsx | 11 +++++++---- src/stories/context-menu.stories.tsx | 2 +- src/stories/dropdown.stories.tsx | 2 +- 5 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/components/ui/choice-box.tsx b/src/components/ui/choice-box.tsx index a91f52b..fcbf510 100644 --- a/src/components/ui/choice-box.tsx +++ b/src/components/ui/choice-box.tsx @@ -128,7 +128,7 @@ interface ChoiceBoxItemProps extends GridListItemProps, VariantProps { - const textValue = typeof children === "string" ? children : undefined; + const textValue = typeof children === "string" ? children : (props.textValue ?? label); const { columns, isReadOnly } = useChoiceBoxContext(); return ( { - const textValue = typeof children === "string" ? children : undefined; + const textValue = typeof children === "string" ? children : props.textValue; return ( + {tooltip} @@ -40,8 +43,8 @@ interface TrackerProps extends ComponentProps<"div">, Pick { return (
- {data.map((props, index) => ( - + {data.map(({ key, ...block }, index) => ( + ))}
); diff --git a/src/stories/context-menu.stories.tsx b/src/stories/context-menu.stories.tsx index c87f7ca..1a5299f 100644 --- a/src/stories/context-menu.stories.tsx +++ b/src/stories/context-menu.stories.tsx @@ -18,7 +18,7 @@ const meta = { Right click here - + Cut Copy diff --git a/src/stories/dropdown.stories.tsx b/src/stories/dropdown.stories.tsx index 21e19f1..2e247f2 100644 --- a/src/stories/dropdown.stories.tsx +++ b/src/stories/dropdown.stories.tsx @@ -12,7 +12,7 @@ const meta = { New file Copy link - + Edit Make changes to this item From 067a3363852650afac54365f3cd3de3bb3590f75 Mon Sep 17 00:00:00 2001 From: Shavonn Brown Date: Fri, 3 Jul 2026 21:08:47 -0400 Subject: [PATCH 3/3] build: test/lint workflow --- .github/workflows/ci.yml | 53 +++++++++++++++++++++++++++++++++++ .github/workflows/release.yml | 6 ++++ 2 files changed, 59 insertions(+) create mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 0000000..45ccc6c --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,53 @@ +name: CI + +on: + push: + branches: [ main ] + pull_request: + workflow_call: + +jobs: + lint: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v6 + + - name: Setup Node + uses: actions/setup-node@v6 + with: + node-version: '24' + + - name: Set up Bun + uses: oven-sh/setup-bun@v2 + with: + bun-version: latest + + - name: Install Dependencies + run: bun install + + - name: Lint + run: bun run lint:check + + test: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v6 + + - name: Setup Node + uses: actions/setup-node@v6 + with: + node-version: '24' + + - name: Set up Bun + uses: oven-sh/setup-bun@v2 + with: + bun-version: latest + + - name: Install Dependencies + run: bun install + + - name: Install Playwright browser + run: bunx playwright install --with-deps chromium + + - name: Run Tests + run: bun run test diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 81c4d9f..155d408 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -9,7 +9,13 @@ permissions: pull-requests: write jobs: + # Re-run lint + tests at merge time; the release is gated on them passing. + ci: + if: github.event.pull_request.merged == true + uses: ./.github/workflows/ci.yml + release: + needs: ci if: github.event.pull_request.merged == true runs-on: ubuntu-latest steps: