Skip to content

Commit ac4f45d

Browse files
committed
Update MeasurementCrudUseCases.kt to ensure the newly generated measurement ID is passed to the sync triggers during insertion and remove unused filtering and aggregation methods from MeasurementFacade.kt.
1 parent 9c1b377 commit ac4f45d

2 files changed

Lines changed: 4 additions & 33 deletions

File tree

android_app/app/src/main/java/com/health/openscale/core/facade/MeasurementFacade.kt

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -113,22 +113,6 @@ class MeasurementFacade @Inject constructor(
113113
}
114114
}
115115

116-
// -------------------------------------------------------------------------
117-
// Time-filtered enriched flow (no aggregation, used internally)
118-
// -------------------------------------------------------------------------
119-
120-
fun timeFilteredEnrichedFlow(
121-
userId: Int,
122-
measurementTypesFlow: Flow<List<MeasurementType>>,
123-
startTimeMillis: Long?,
124-
endTimeMillis: Long?,
125-
): Flow<List<EnrichedMeasurement>> =
126-
filter.getTimeFiltered(
127-
enrichedFlowForUser(userId, measurementTypesFlow),
128-
startTimeMillis,
129-
endTimeMillis,
130-
)
131-
132116
// -------------------------------------------------------------------------
133117
// Full pipeline: query → enrich → filter → smooth → aggregate
134118
// -------------------------------------------------------------------------
@@ -188,15 +172,6 @@ class MeasurementFacade @Inject constructor(
188172
)
189173
}
190174

191-
// -------------------------------------------------------------------------
192-
// Convenience wrapper (used by callers that already have a list)
193-
// -------------------------------------------------------------------------
194-
195-
fun aggregateList(
196-
measurements: List<EnrichedMeasurement>,
197-
level: AggregationLevel,
198-
): List<AggregatedMeasurement> = aggregation.aggregate(measurements, level)
199-
200175
// -------------------------------------------------------------------------
201176
// BLE
202177
// -------------------------------------------------------------------------
@@ -278,9 +253,4 @@ class MeasurementFacade @Inject constructor(
278253
selectedTimestamp: Long,
279254
items: List<MeasurementWithValues>,
280255
) = query.findClosestMeasurement(selectedTimestamp, items)
281-
282-
fun filterByTypes(
283-
measurements: List<EnrichedMeasurement>,
284-
selectedTypeIds: Set<Int>,
285-
): List<EnrichedMeasurement> = filter.filterByTypes(measurements, selectedTypeIds)
286256
}

android_app/app/src/main/java/com/health/openscale/core/usecase/MeasurementCrudUseCases.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,14 +74,15 @@ class MeasurementCrudUseCases @Inject constructor(
7474
if (measurement.id == 0) {
7575
// Insert path
7676
val newId = databaseRepository.insertMeasurement(measurement).toInt()
77+
val measurementWithId = measurement.copy(id = newId)
7778

7879
finalValues.forEach { v ->
7980
databaseRepository.insertMeasurementValue(v.copy(measurementId = newId))
8081
}
8182

82-
sync.triggerSyncInsert(measurement, finalValues,"com.health.openscale.sync")
83-
sync.triggerSyncInsert(measurement, finalValues,"com.health.openscale.sync.oss")
84-
sync.triggerSyncInsert(measurement, finalValues,"com.health.openscale.sync.debug")
83+
sync.triggerSyncInsert(measurementWithId, finalValues,"com.health.openscale.sync")
84+
sync.triggerSyncInsert(measurementWithId, finalValues,"com.health.openscale.sync.oss")
85+
sync.triggerSyncInsert(measurementWithId, finalValues,"com.health.openscale.sync.debug")
8586

8687
MeasurementWidget.refreshAll(appContext)
8788

0 commit comments

Comments
 (0)