fix(core): preserve non-translatable xcstrings entries on edit set

Author: WendellXY

langcodec-cli/tests/edit_cli_tests.rs

@@ -505,3 +505,73 @@ fn test_edit_set_xcstrings_preserves_is_comment_auto_generated() {
         serde_json::Value::Bool(true)
     );
 }
+
+#[test]
+fn test_edit_set_xcstrings_preserves_non_translatable_entry_without_localizations() {
+    let temp_dir = TempDir::new().unwrap();
+    let input_file = temp_dir.path().join("Localizable.xcstrings");
+    let initial = r#"{
+  "sourceLanguage": "en",
+  "version": "1.0",
+  "strings": {
+    "game_title": {
+      "localizations": {
+        "en": {
+          "stringUnit": {
+            "state": "translated",
+            "value": "Game"
+          }
+        }
+      }
+    },
+    "Carrom": {
+      "comment": "The text label for the Carrom game button.",
+      "isCommentAutoGenerated": true,
+      "shouldTranslate": false
+    }
+  }
+}
+"#;
+    fs::write(&input_file, initial).unwrap();
+
+    let out = langcodec_cmd()
+        .args([
+            "edit",
+            "set",
+            "-i",
+            input_file.to_str().unwrap(),
+            "--lang",
+            "en",
+            "-k",
+            "game_title",
+            "-v",
+            "Game Updated",
+        ])
+        .output()
+        .unwrap();
+    assert!(
+        out.status.success(),
+        "stderr: {}",
+        String::from_utf8_lossy(&out.stderr)
+    );
+
+    let content = fs::read_to_string(&input_file).unwrap();
+    let payload: serde_json::Value = serde_json::from_str(&content).unwrap();
+
+    assert_eq!(
+        payload["strings"]["Carrom"]["comment"],
+        "The text label for the Carrom game button."
+    );
+    assert_eq!(
+        payload["strings"]["Carrom"]["isCommentAutoGenerated"],
+        serde_json::Value::Bool(true)
+    );
+    assert_eq!(
+        payload["strings"]["Carrom"]["shouldTranslate"],
+        serde_json::Value::Bool(false)
+    );
+    assert_eq!(
+        payload["strings"]["game_title"]["localizations"]["en"]["stringUnit"]["value"],
+        "Game Updated"
+    );
+}

langcodec/src/formats/xcstrings.rs

@@ -161,6 +161,30 @@ impl TryFrom<Format> for Vec<Resource> {
                                 custom: custom.clone(),
                             });
                     }
+                } else {
+                    // Preserve non-translatable metadata-only entries by attaching an empty
+                    // do-not-translate entry to source language.
+                    let source_language = custom_meta
+                        .get("source_language")
+                        .cloned()
+                        .unwrap_or_else(|| "en".to_string());
+                    resource_map
+                        .entry(source_language.clone())
+                        .or_insert(Resource {
+                            metadata: Metadata {
+                                language: source_language,
+                                domain: String::default(),
+                                custom: custom_meta.clone(),
+                            },
+                            entries: Vec::new(),
+                        })
+                        .add_entry(Entry {
+                            id: id.clone(),
+                            value: Translation::Empty,
+                            comment: item.comment.clone(),
+                            status: EntryStatus::DoNotTranslate,
+                            custom: custom.clone(),
+                        });
                 }
                 continue;
             }
@@ -552,4 +576,53 @@ mod tests {
             assert_eq!(empty_entry.comment.as_deref(), Some("Missing translation"));
         }
     }
+
+    #[test]
+    fn test_non_translatable_item_without_localizations_is_preserved() {
+        let mut strings = HashMap::new();
+        strings.insert(
+            "game_title".to_string(),
+            Item {
+                localizations: {
+                    let mut localizations = HashMap::new();
+                    localizations.insert(
+                        "en".to_string(),
+                        Localization::from(StringUnit::new(EntryStatus::Translated, "Game")),
+                    );
+                    localizations
+                },
+                comment: None,
+                extraction_state: None,
+                should_translate: Some(true),
+                is_comment_auto_generated: None,
+            },
+        );
+        strings.insert(
+            "Carrom".to_string(),
+            Item {
+                localizations: HashMap::new(),
+                comment: Some("The text label for the Carrom game button.".to_string()),
+                extraction_state: None,
+                should_translate: Some(false),
+                is_comment_auto_generated: Some(true),
+            },
+        );
+        let format = Format {
+            source_language: "en".to_string(),
+            version: "1.0".to_string(),
+            strings,
+        };
+
+        let resources = Vec::<Resource>::try_from(format).expect("resources from xcstrings");
+        let roundtrip = Format::try_from(resources).expect("xcstrings from resources");
+        let carrom = roundtrip.strings.get("Carrom").expect("Carrom item exists");
+
+        assert!(carrom.localizations.is_empty());
+        assert_eq!(
+            carrom.comment.as_deref(),
+            Some("The text label for the Carrom game button.")
+        );
+        assert_eq!(carrom.should_translate, Some(false));
+        assert_eq!(carrom.is_comment_auto_generated, Some(true));
+    }
 }