fix(cli): keep json output machine-readable with plural checks

Author: WendellXY

langcodec-cli/src/main.rs

@@ -578,7 +578,13 @@ fn main() {
 
             if check_plurals {
                 match codec.validate_plurals() {
-                    Ok(()) => println!("\n✅ Plural validation passed"),
+                    Ok(()) => {
+                        if json {
+                            eprintln!("✅ Plural validation passed");
+                        } else {
+                            println!("\n✅ Plural validation passed");
+                        }
+                    }
                     Err(e) => {
                         eprintln!("\n❌ Plural validation failed: {}", e);
                         std::process::exit(2);

langcodec-cli/src/view.rs

@@ -170,8 +170,9 @@ fn render_json_output(
 
 /// Print a view of the resources in a codec.
 pub fn print_view(codec: &Codec, lang_filter: &Option<String>, opts: &ViewOptions) {
-    let keys_only_text = opts.keys_only && !opts.json;
-    if !keys_only_text && !opts.json {
+    let text_mode = !opts.json;
+    let keys_only_text = opts.keys_only && text_mode;
+    if text_mode && !keys_only_text {
         println!("Processing resources...");
     }
     let status_filter = match parse_status_filter(&opts.status) {
@@ -216,10 +217,6 @@ pub fn print_view(codec: &Codec, lang_filter: &Option<String>, opts: &ViewOption
         std::process::exit(1);
     }
 
-    if !keys_only_text && !opts.json {
-        println!("✅ Found {} resource(s)", resources.len());
-    }
-
     let filtered_resources = resources
         .iter()
         .map(|resource| {
@@ -236,8 +233,21 @@ pub fn print_view(codec: &Codec, lang_filter: &Option<String>, opts: &ViewOption
         })
         .collect::<Vec<_>>();
 
+    let visible_resources = if status_filter.is_some() {
+        filtered_resources
+            .into_iter()
+            .filter(|(_, entries)| !entries.is_empty())
+            .collect::<Vec<_>>()
+    } else {
+        filtered_resources
+    };
+
+    if text_mode && !keys_only_text {
+        println!("✅ Found {} resource(s)", visible_resources.len());
+    }
+
     if opts.json {
-        let rendered = match render_json_output(&filtered_resources, opts.keys_only) {
+        let rendered = match render_json_output(&visible_resources, opts.keys_only) {
             Ok(text) => text,
             Err(err) => {
                 eprintln!("❌ {}", err);
@@ -250,7 +260,7 @@ pub fn print_view(codec: &Codec, lang_filter: &Option<String>, opts: &ViewOption
 
     if keys_only_text {
         let include_lang_prefix = lang_filter.is_none();
-        for (resource, entries) in &filtered_resources {
+        for (resource, entries) in &visible_resources {
             for entry in entries {
                 if include_lang_prefix {
                     println!("{}\t{}", resource.metadata.language, entry.id);
@@ -262,7 +272,7 @@ pub fn print_view(codec: &Codec, lang_filter: &Option<String>, opts: &ViewOption
         return;
     }
 
-    for (i, (resource, entries)) in filtered_resources.iter().enumerate() {
+    for (i, (resource, entries)) in visible_resources.iter().enumerate() {
         println!("\n=== Resource {} ===", i + 1);
         println!("Language: {}", resource.metadata.language);
         println!("Domain: {}", resource.metadata.domain);
@@ -309,7 +319,7 @@ pub fn print_view(codec: &Codec, lang_filter: &Option<String>, opts: &ViewOption
     if lang_filter.is_none() {
         let mut unique_keys = HashSet::new();
         let mut per_language_counts: BTreeMap<String, usize> = BTreeMap::new();
-        for (resource, entries) in &filtered_resources {
+        for (resource, entries) in &visible_resources {
             per_language_counts
                 .entry(resource.metadata.language.clone())
                 .and_modify(|count| *count += entries.len())

langcodec-cli/tests/view_status_cli_tests.rs

@@ -630,3 +630,81 @@ fn test_view_status_json_keys_only_lang_uses_consistent_object_schema() {
     assert!(keys.iter().all(|item| item["lang"] == "en"));
     assert!(keys.iter().all(|item| item["key"] == "needs_review_key"));
 }
+
+#[test]
+fn test_view_status_json_with_check_plurals_keeps_stdout_json() {
+    let temp_dir = TempDir::new().unwrap();
+    let input_file = temp_dir.path().join("Localizable.xcstrings");
+    write_xcstrings_multilang_fixture(&input_file);
+
+    let output = langcodec_cmd()
+        .args([
+            "view",
+            "-i",
+            input_file.to_str().unwrap(),
+            "--status",
+            "needs_review",
+            "--json",
+            "--check-plurals",
+        ])
+        .output()
+        .unwrap();
+
+    assert!(
+        output.status.success(),
+        "CLI failed: {}",
+        String::from_utf8_lossy(&output.stderr)
+    );
+
+    let stdout = String::from_utf8_lossy(&output.stdout);
+    let _payload: serde_json::Value = serde_json::from_str(&stdout)
+        .unwrap_or_else(|e| panic!("Expected JSON output. parse error: {e}. stdout: {stdout}"));
+
+    let stderr = String::from_utf8_lossy(&output.stderr);
+    assert!(
+        stderr.contains("Plural validation passed"),
+        "Expected plural validation success in stderr. stderr: {}",
+        stderr
+    );
+}
+
+#[test]
+fn test_view_status_text_excludes_zero_match_languages_from_output_and_summary() {
+    let temp_dir = TempDir::new().unwrap();
+    let input_file = temp_dir.path().join("Localizable.xcstrings");
+    write_xcstrings_partial_match_fixture(&input_file);
+
+    let output = langcodec_cmd()
+        .args([
+            "view",
+            "-i",
+            input_file.to_str().unwrap(),
+            "--status",
+            "needs_review",
+        ])
+        .output()
+        .unwrap();
+
+    assert!(
+        output.status.success(),
+        "CLI failed: {}",
+        String::from_utf8_lossy(&output.stderr)
+    );
+
+    let stdout = String::from_utf8_lossy(&output.stdout);
+    assert!(
+        stdout.contains("Language: en"),
+        "Expected matched language in output. stdout: {}",
+        stdout
+    );
+    assert!(
+        !stdout.contains("Language: fr"),
+        "Expected zero-match language to be excluded. stdout: {}",
+        stdout
+    );
+    assert!(
+        stdout.contains("Total languages: 1"),
+        "Expected summary to count only matching languages. stdout: {}",
+        stdout
+    );
+}