Improve error for method body syntax errors - close #78

Author: sandrokeil

src/Code/MethodGenerator.php

@@ -15,6 +15,7 @@
 use OpenCodeModeling\CodeAst\Code\DocBlock\Tag\ReturnTag;
 use OpenCodeModeling\CodeAst\Exception;
 use PhpParser\Comment\Doc;
+use PhpParser\Error;
 use PhpParser\Node\Stmt\ClassMethod;
 
 /**
@@ -215,21 +216,33 @@ public function overrideDocBlock(?DocBlock $docBlock): void
 
     public function generate(): ClassMethod
     {
-        return new ClassMethod(
-            $this->getName(),
-            [
-                'flags' => $this->flags,
-                'params' => \array_map(
-                    static function (ParameterGenerator $parameter) {
-                        return $parameter->generate();
-                    },
-                    $this->getParameters()
+        try {
+            return new ClassMethod(
+                $this->getName(),
+                [
+                    'flags' => $this->flags,
+                    'params' => \array_map(
+                        static function (ParameterGenerator $parameter) {
+                            return $parameter->generate();
+                        },
+                        $this->getParameters()
+                    ),
+                    'stmts' => $this->body ? $this->body->generate() : null,
+                    'returnType' => $this->returnType ? $this->returnType->generate() : null,
+                ],
+                $this->generateAttributes()
+            );
+        } catch (Error $e) {
+            throw new Exception\RuntimeException(
+                \sprintf(
+                    'Could not generate method "%s" due the following error: %s',
+                    $this->getName(),
+                    $e->getMessage()
                 ),
-                'stmts' => $this->body ? $this->body->generate() : null,
-                'returnType' => $this->returnType ? $this->returnType->generate() : null,
-            ],
-            $this->generateAttributes()
-        );
+                (int) $e->getCode(),
+                $e
+            );
+        }
     }
 
     private function generateAttributes(): array

tests/Code/MethodGeneratorTest.php

@@ -10,9 +10,11 @@
 
 namespace OpenCodeModelingTest\CodeAst\Code;
 
+use OpenCodeModeling\CodeAst\Code\BodyGenerator;
 use OpenCodeModeling\CodeAst\Code\DocBlock\DocBlock;
 use OpenCodeModeling\CodeAst\Code\MethodGenerator;
 use OpenCodeModeling\CodeAst\Code\ParameterGenerator;
+use OpenCodeModeling\CodeAst\Exception\RuntimeException;
 use PhpParser\Parser;
 use PhpParser\ParserFactory;
 use PhpParser\PrettyPrinter\Standard;
@@ -262,4 +264,26 @@ public function setType(string $type, ?int $value);
 
         $this->assertSame($expectedOutput, $this->printer->prettyPrintFile([$method->generate()]));
     }
+
+    /**
+     * @test
+     */
+    public function it_catches_body_parse_errors_and_throws_runtime_exception(): void
+    {
+        $method = new MethodGenerator(
+            'setType',
+            [
+                new ParameterGenerator('type', '?string'),
+            ],
+            MethodGenerator::FLAG_PUBLIC,
+            new BodyGenerator($this->parser, '$test=1; error=true')
+        );
+        $method->setTyped(true);
+        $method->setReturnType('void');
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('Could not generate method "setType" due the following error');
+
+        $this->printer->prettyPrintFile([$method->generate()]);
+    }
 }