Skip to content

Commit 46fdcd7

Browse files
committed
Fix MessageCenterTests
1 parent 927cada commit 46fdcd7

3 files changed

Lines changed: 5 additions & 9 deletions

File tree

Source/Processors/MessageCenter/MessageCenter.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,11 @@ void MessageCenter::broadcastMessage (const String& msg, const int64 systemTimeM
144144

145145
void MessageCenter::addOutgoingMessage (const String& msg, const int64 systemTimeMilliseconds)
146146
{
147-
messageCenterEditor->addOutgoingMessage (msg, systemTimeMilliseconds);
147+
broadcastMessage (msg, systemTimeMilliseconds);
148+
addSavedMessage (msg);
149+
150+
if(messageCenterEditor != nullptr)
151+
messageCenterEditor->addOutgoingMessage (msg, systemTimeMilliseconds);
148152
}
149153

150154
void MessageCenter::addSavedMessage (const String& msg)

Source/Processors/MessageCenter/MessageCenterEditor.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,6 @@ void MessageCenterEditor::addIncomingMessage (const String& message)
153153

154154
void MessageCenterEditor::addOutgoingMessage (const String& message, const int64 systemTime)
155155
{
156-
messageCenter->broadcastMessage (message, systemTime);
157-
messageCenter->addSavedMessage (message);
158156
editableMessageDisplayArea->setText (message, dontSendNotification);
159157

160158
outgoingMessageLog->addMessage (new MessageLabel ("message", message));

Tests/Processors/MessageCenterTests.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ TEST_F(MessageCenterTests, GetMessageStream)
4040

4141
TEST_F(MessageCenterTests, AddOutgoingMessage)
4242
{
43-
GTEST_SKIP() << "Need headless support for MessageCenter";
44-
4543
messageCenter->addOutgoingMessage("Test Message", 100);
4644
EXPECT_EQ(messageCenter->getSavedMessages().size(), 1);
4745

@@ -51,8 +49,6 @@ TEST_F(MessageCenterTests, AddOutgoingMessage)
5149

5250
TEST_F(MessageCenterTests, AddSavedMessage)
5351
{
54-
GTEST_SKIP() << "Need headless support for MessageCenter";
55-
5652
messageCenter->addSavedMessage("Test Message");
5753
EXPECT_EQ(messageCenter->getSavedMessages().size(), 1);
5854

@@ -62,8 +58,6 @@ TEST_F(MessageCenterTests, AddSavedMessage)
6258

6359
TEST_F(MessageCenterTests, ClearSavedMessages)
6460
{
65-
GTEST_SKIP() << "Need headless support for MessageCenter";
66-
6761
messageCenter->addSavedMessage("Test Message");
6862
EXPECT_EQ(messageCenter->getSavedMessages().size(), 1);
6963

0 commit comments

Comments
 (0)