Skip to content

Commit 522efbc

Browse files
committed
Update change message for MaskChannelsParameter
1 parent 7f586b3 commit 522efbc

2 files changed

Lines changed: 29 additions & 12 deletions

File tree

Source/Processors/GenericProcessor/GenericProcessor.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1919,7 +1919,6 @@ void GenericProcessor::loadFromXml()
19191919
}
19201920
else
19211921
{
1922-
jassertfalse;
19231922
LOGD ("Stream parameter not found: ", name, ". Skipping...");
19241923
continue;
19251924
}
@@ -2099,4 +2098,4 @@ GenericProcessor::DefaultEventInfo::DefaultEventInfo()
20992098
length (0),
21002099
sampleRate (44100)
21012100
{
2102-
}
2101+
}

Source/Processors/Parameter/Parameter.cpp

Lines changed: 28 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -977,27 +977,45 @@ String MaskChannelsParameter::getChangeDescription()
977977
curr.add (currentValue[i]);
978978
}
979979

980-
//find how many values different from prev to curr
981-
int diff = 0;
980+
//find how many values in current were not in previous
981+
int added = 0;
982982

983983
for (int i = 0; i < curr.size(); i++)
984984
{
985985
if (! prev.contains (curr[i]))
986-
diff++;
986+
added++;
987987
}
988+
989+
// find how many values in previous are not in current
990+
int removed = 0;
988991

989992
for (int i = 0; i < prev.size(); i++)
990993
{
991994
if (! curr.contains (prev[i]))
992-
diff++;
995+
removed++;
993996
}
997+
998+
String selectionString;
994999

995-
if (diff == 0) //should never get here
996-
return "No change";
997-
else if (diff == 1)
998-
return "changed 1";
999-
else
1000-
return "changed " + String (diff);
1000+
if (added > 0) //should never get here
1001+
selectionString += "added " + String(added);
1002+
1003+
if (removed > 0)
1004+
{
1005+
if (selectionString.length() > 0)
1006+
selectionString += ", ";
1007+
selectionString += "removed " + String(removed);
1008+
}
1009+
1010+
selectionString += " channel";
1011+
1012+
if (added > 1 || removed > 1)
1013+
selectionString += "s";
1014+
1015+
if (added == 0 && removed == 0)
1016+
selectionString = "no change";
1017+
1018+
return selectionString;
10011019
}
10021020

10031021
void MaskChannelsParameter::toXml (XmlElement* xml)

0 commit comments

Comments
 (0)