Refactor PluginManagerTests to use test fixture and improve plugin loading tests

Author: anjaldoshi

Tests/Processors/PluginManagerTests.cpp

@@ -2,76 +2,64 @@
 
 #include <ProcessorHeaders.h>
 #include <Processors/PluginManager/PluginManager.h>
+class PluginManagerTest : public testing::Test
+{
+protected:
+    void SetUp() override
+    {
+        files =
+        File::getCurrentWorkingDirectory().getChildFile ("../ArduinoOutput").findChildFiles (File::findFiles, false, "ArduinoOutput.*", File::FollowSymlinks::no);
+
+        ASSERT_EQ (files.size(), 1);
+
+        String path = files[0].getFullPathName();
+
+        pluginManager.loadPlugin(path);
+
+    }
+
+    PluginManager pluginManager;
+
+private:
+    Array<File> files;
+};
 
 /*
-The Plugin Manager will be passed an absolute path to a DLL containing a Plugin library. 
 The Plugin Manager should load the DLL without warning or errors. 
 The Plugin Manager should record library information from the DLL that will be verified.
 */
-TEST(PluginManagerTest, PluginLoading)
+TEST_F (PluginManagerTest, PluginLoading)
 {
-    PluginManager pluginManager;
-
-    String path = 
-        File::getCurrentWorkingDirectory().
-        getChildFile("../Resources/ArduinoOutput.dll").
-        getFullPathName();
-
-    pluginManager.loadPlugin(path);
-
-    EXPECT_EQ(pluginManager.getLibraryName(0), "Arduino Output");
+    EXPECT_EQ (pluginManager.getNumProcessors(), 1);
+    EXPECT_EQ (pluginManager.getLibraryName (0), "Arduino Output");
 }
 
 /*
-The Plugin Manager will first load a Plugin DLL. 
-A Plugin Description will be passed to the Plugin Manager, 
-which will output an instance of the Processor by 
-locating the associated Library Info object containing the Processor's constructor.
+Find the processor information from the Plugin Manager and verify the processor can be created.
 */
-TEST(PluginManagerTest, PluginCreation)
+TEST_F (PluginManagerTest, PluginCreation)
 {
-    PluginManager pluginManager;
-
-    String path =
-        File::getCurrentWorkingDirectory().
-        getChildFile("../Resources/ArduinoOutput.dll").
-        getFullPathName();
-
-    int idx = pluginManager.loadPlugin(path) - 1;
-    Plugin::ProcessorInfo processorInfo = pluginManager.getProcessorInfo(idx);
+    Plugin::ProcessorInfo processorInfo = pluginManager.getProcessorInfo(0);
 
     EXPECT_EQ(String(processorInfo.name), "Arduino Output");
     EXPECT_EQ(processorInfo.type, Plugin::Processor::SINK);
+    EXPECT_NE(processorInfo.creator, nullptr);
 }
 
-TEST(PluginManagerTest, getLibraryIndexFromPlugin)
+TEST_F (PluginManagerTest, getLibraryIndexFromPlugin)
 {
-    PluginManager pluginManager;
-
-    String path =
-        File::getCurrentWorkingDirectory().
-        getChildFile("../Resources/ArduinoOutput.dll").
-        getFullPathName();
-
-    int idx = pluginManager.loadPlugin(path) - 1;
     Plugin::Type type = Plugin::Type::PROCESSOR;
 
-    EXPECT_EQ(pluginManager.getLibraryIndexFromPlugin(type, idx), 0);
+    EXPECT_EQ (pluginManager.getLibraryIndexFromPlugin (type, 0), 0);
 }
 
-TEST(PluginManagerTest, removePlugin)
+TEST_F (PluginManagerTest, removePlugin)
 {
-    PluginManager pluginManager;
-
-    String path =
-        File::getCurrentWorkingDirectory().
-        getChildFile("../Resources/ArduinoOutput.dll").
-        getFullPathName();
+    auto libName = pluginManager.getLibraryName (0);
 
-    int idx = pluginManager.loadPlugin(path) - 1;
-    Plugin::ProcessorInfo processorInfo = pluginManager.getProcessorInfo(idx);
+    ASSERT_EQ (libName, "Arduino Output");
 
-    pluginManager.removePlugin(processorInfo.name);
+    pluginManager.removePlugin (libName);
 
-    EXPECT_EQ(pluginManager.getNumProcessors(), 0);
+    EXPECT_EQ (pluginManager.getNumProcessors(), 0);
 }