Refactor RecordControl parameters and editor

Author: anjaldoshi

Plugins/RecordControl/RecordControl.cpp

@@ -25,6 +25,10 @@
 
 RecordControl::RecordControl()
     : GenericProcessor ("Record Control")
+{
+}
+
+void RecordControl::registerParameters()
 {
     addCategoricalParameter (Parameter::PROCESSOR_SCOPE,
                              "trigger_type",
@@ -40,13 +44,11 @@ RecordControl::RecordControl()
                              { "Rising", "Falling" },
                              0);
 
-    addIntParameter (Parameter::STREAM_SCOPE,
-                     "trigger_line",
-                     "Trigger line",
-                     "The TTL line that triggers a change in recording state",
-                     1,
-                     1,
-                     16);
+    addTtlLineParameter (Parameter::STREAM_SCOPE,
+                         "trigger_line",
+                         "Trigger line",
+                         "The TTL line that triggers a change in recording state",
+                         16);
 }
 
 AudioProcessorEditor* RecordControl::createEditor()
@@ -55,7 +57,7 @@ AudioProcessorEditor* RecordControl::createEditor()
     return editor.get();
 }
 
-void RecordControl::process (AudioSampleBuffer& buffer)
+void RecordControl::process (AudioBuffer<float>& buffer)
 {
     checkForEvents();
 }
@@ -64,7 +66,7 @@ void RecordControl::handleTTLEvent (TTLEventPtr event)
 {
     DataStream* stream = getDataStream (event->getStreamId());
 
-    if (event->getLine() == (int ((*stream)["trigger_line"]) - 1))
+    if (event->getLine() == (int ((*stream)["trigger_line"])))
     {
         if (int (getParameter ("trigger_type")->getValue()) == 0) // edge set
         {

Plugins/RecordControl/RecordControl.h

@@ -42,6 +42,9 @@ class RecordControl : public GenericProcessor
     /** Destructor */
     ~RecordControl() {}
 
+    /** Registers the parameters */
+    void registerParameters() override;
+
     /** Create Record Control Editor*/
     AudioProcessorEditor* createEditor() override;
 

Plugins/RecordControl/RecordControlEditor.cpp

@@ -28,9 +28,9 @@
 RecordControlEditor::RecordControlEditor (GenericProcessor* parentNode)
     : GenericEditor (parentNode)
 {
-    desiredWidth = 200;
+    desiredWidth = 175;
 
-    addComboBoxParameterEditor (Parameter::PROCESSOR_SCOPE, "trigger_type", 15, 30);
-    addComboBoxParameterEditor (Parameter::PROCESSOR_SCOPE, "edge", 15, 74);
-    addComboBoxParameterEditor (Parameter::STREAM_SCOPE, "trigger_line", 110, 74);
+    addComboBoxParameterEditor (Parameter::PROCESSOR_SCOPE, "trigger_type", 10, 35);
+    addComboBoxParameterEditor (Parameter::PROCESSOR_SCOPE, "edge", 10, 65);
+    addTtlLineParameterEditor (Parameter::STREAM_SCOPE, "trigger_line", 10, 95);
 }