Skip to content

Commit e8b9e02

Browse files
committed
Update ReadWrite test in MidiBufferTests
1 parent 185d808 commit e8b9e02

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

Tests/Juce/MidiBufferTests.cpp

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ class MidiBufferTests : public testing::Test
4343
};
4444

4545
continuousChannel = std::make_unique<ContinuousChannel>(continuousChannelSettings);
46-
dataStream->addChannel(continuousChannel.get());
4746

4847
// Set the source node id for the data stream
4948
nodeId = 0;
@@ -57,6 +56,8 @@ class MidiBufferTests : public testing::Test
5756
processor = std::make_unique<MockProcessor>();
5857
processor->setNodeId(nodeId);
5958

59+
dataStream->addProcessor (processor.get());
60+
continuousChannel->addProcessor (processor.get());
6061
eventChannel->addProcessor(processor.get());
6162

6263
event = TTLEvent::createTTLEvent(eventChannel.get(), 0, 0, true);
@@ -78,8 +79,6 @@ This test verifies that multiple Metadata objects inserted into the Midi Buffer
7879
*/
7980
TEST_F(MidiBufferTests, ReadWrite)
8081
{
81-
GTEST_SKIP() << "Fix";
82-
8382
size_t size = event->getChannelInfo()->getDataSize() +
8483
event->getChannelInfo()->getTotalEventMetadataSize() +
8584
EVENT_BASE_SIZE;
@@ -96,11 +95,15 @@ TEST_F(MidiBufferTests, ReadWrite)
9695
{
9796
auto metaData = *it;
9897

99-
auto expectedMetaData = packet.getMetaEventData();
100-
auto expectedMetaDataLength = packet.getMetaEventLength();
98+
auto expectedMetaData = packet.getRawData();
99+
auto expectedMetaDataLength = packet.getRawDataSize();
101100

102101
EXPECT_EQ (metaData.numBytes, expectedMetaDataLength);
103-
EXPECT_EQ (metaData.data, expectedMetaData);
102+
103+
for (int i = 0; i < expectedMetaDataLength; ++i)
104+
{
105+
EXPECT_EQ (metaData.data[i], expectedMetaData[i]);
106+
}
104107
}
105108
}
106109

0 commit comments

Comments
 (0)