Fix and regression test for #84

Author: apdavison

pipeline/src/base.py

@@ -77,7 +77,7 @@ def to_jsonld(self, include_empty_properties=True, embed_linked_nodes=True, with
             data["@id"] = self.id
         for property in self.__class__.properties:
             value = getattr(self, property.name)
-            if value or include_empty_properties:
+            if (value is not None) or include_empty_properties:
                 if property.multiple:
                     if value is None:
                         data[property.path] = value

pipeline/tests/test_regressions.py

@@ -337,11 +337,19 @@ def test_pr0083(om):
     # https://github.com/openMetadataInitiative/openMINDS_Python/pull/83
     # by_name() should return None consistently
     # when no matches are found, regardless of the 'all' parameter
-    
+
     # all=False (default) should return None when no match is found
     result = om.controlled_terms.BiologicalOrder.by_name("nonexistent_order_xyz")
     assert result is None
-    
+
     # all=True should also return None when no match is found
     results = om.controlled_terms.BiologicalOrder.by_name("nonexistent_order_xyz", all=True)
-    assert results is None
+    assert results is None
+
+@pytest.mark.parametrize("om", [openminds.latest, openminds.v4])
+def test_issue0084(om):
+    # Properties whose value evaluates to False (e.g., zero)
+    # are not serialized if using include_empty_properties=False
+    obj = om.publications.LivePaperSection(name="test", order=0)
+    data = obj.to_jsonld(include_empty_properties=False)
+    assert data == {"name": "test", "order": 0}