77from openminds import Collection , IRI
88import openminds .latest
99import openminds .v4
10+ import openminds .v5
1011from utils import build_fake_node
1112
1213
@@ -65,8 +66,8 @@ def test_issue_0003(om):
6566 )
6667
6768
68- @pytest .mark .parametrize ("om" , [openminds .latest , openminds . v4 ])
69- def test_issue0005 (om ):
69+ @pytest .mark .parametrize ("om" , [openminds .v4 ])
70+ def test_issue0005a (om ):
7071 # https://github.com/openMetadataInitiative/openMINDS_Python/issues/5
7172 # validate() does not complain about list/tuple entries that should be a direct single entry
7273 uni1 = om .core .Organization (full_name = "University of This Place" )
@@ -82,9 +83,26 @@ def test_issue0005(om):
8283 failures = person .validate ()
8384 assert len (failures ) == 0
8485
86+ @pytest .mark .parametrize ("om" , [openminds .v5 , openminds .latest ])
87+ def test_issue0005b (om ):
88+ # https://github.com/openMetadataInitiative/openMINDS_Python/issues/5
89+ # validate() does not complain about list/tuple entries that should be a direct single entry
90+ person = om .core .Person (
91+ preferred_name = "A" ,
92+ family_name = "Professor"
93+ )
94+ uni1 = om .core .Organization (name = "University of This Place" , country_of_formation = om .controlled_terms .sovereign_state .SovereignState .by_name ("Germany" ), type = om .controlled_terms .organization_type .OrganizationType .by_name ('organizational unit' ), memberships = [om .core .Membership (member = person , end_date = (2023 , 9 , 30 ))])
95+ failures = uni1 .validate ()
96+ assert len (failures ) == 1
8597
86- @pytest .mark .parametrize ("om" , [openminds .latest , openminds .v4 ])
87- def test_issue0007 (om ):
98+ uni1 .memberships [0 ].end_date = date (2023 , 9 , 30 )
99+ print (uni1 .type )
100+ failures = uni1 .validate ()
101+ assert len (failures ) == 0
102+
103+
104+ @pytest .mark .parametrize ("om" , [openminds .v4 ])
105+ def test_issue0007a (om ):
88106 # https://github.com/openMetadataInitiative/openMINDS_Python/issues/7
89107 # Instances of embedded types with value type "array" are not correctly resolved for saving and causing an error.
90108
@@ -157,8 +175,8 @@ def test_issue0007(om):
157175 assert saved_data == expected_saved_data
158176
159177
160- @pytest .mark .parametrize ("om" , [openminds .latest , openminds . v4 ])
161- def test_issue0008 (om ):
178+ @pytest .mark .parametrize ("om" , [openminds .v4 ])
179+ def test_issue0008a (om ):
162180 # https://github.com/openMetadataInitiative/openMINDS_Python/issues/8
163181 # The instance of linked types in instances of embedded types are integrated as embedded not linked
164182 # (example: person -> affiliations (embedded) -> organization (linked))
@@ -188,8 +206,8 @@ def test_issue0008(om):
188206 assert actual == expected
189207
190208
191- @pytest .mark .parametrize ("om" , [openminds .latest , openminds . v4 ])
192- def test_issue0026 (om ):
209+ @pytest .mark .parametrize ("om" , [openminds .v4 ])
210+ def test_issue0026a (om ):
193211 # https://github.com/openMetadataInitiative/openMINDS_Python/issues/26
194212 # When reading a JSON-LD file, the attributes of LinkedMetadata nodes
195213 # inside EmbeddedMetadata nodes are not set properly
@@ -214,8 +232,8 @@ def test_issue0026(om):
214232 assert person_again .affiliations [0 ].member_of .full_name == "University of This Place"
215233
216234
217- @pytest .mark .parametrize ("om" , [openminds .latest , openminds . v4 ])
218- def test_issue0023 (om ):
235+ @pytest .mark .parametrize ("om" , [openminds .v4 ])
236+ def test_issue0023a (om ):
219237 # https://github.com/openMetadataInitiative/openMINDS_Python/issues/23
220238 # If a user adds an instance/node to a collection, and then later adds linked types to the instance,
221239 # currently that is not added to the collection
0 commit comments