Skip to content

feat(agent): forward configured MCP servers#903

Open
carterusedulm2-maker wants to merge 1 commit into
openabdev:mainfrom
carterusedulm2-maker:feat/agent-mcp-servers
Open

feat(agent): forward configured MCP servers#903
carterusedulm2-maker wants to merge 1 commit into
openabdev:mainfrom
carterusedulm2-maker:feat/agent-mcp-servers

Conversation

@carterusedulm2-maker
Copy link
Copy Markdown

@carterusedulm2-maker carterusedulm2-maker commented May 22, 2026

Discord Discussion URL: https://discord.com/channels/1504115981566345299/1507357234156540026/1507357234156540026

Summary

  • Add [agent.mcp_servers] config and convert stdio/http/sse MCP servers into ACP mcpServers.
  • Forward configured MCP servers through both session/new and session/load.
  • Redact MCP env/header values from ACP send debug logs while preserving the actual outbound payload.
  • Document generic MCP config and add Helm values/render tests.

Notes

  • Cargo.lock package version is synced from 0.8.3 to 0.8.4 because upstream Cargo.toml already reports 0.8.4 and cargo check updates the lockfile.
  • Runtime-only MemPalace sync scripts, host configs, systemd units, and validation state are intentionally not included.

Validation

  • cargo check
  • cargo test (403 passed)
  • cargo clippy -- -D warnings
  • git diff --check
  • helm lint charts/openab
  • helm template test charts/openab
  • helm template test charts/openab --set agents.kiro.enabled=false
  • helm unittest charts/openab (10 suites / 100 tests passed)

@github-actions github-actions Bot added closing-soon PR missing Discord Discussion URL — will auto-close in 3 days pending-maintainer and removed closing-soon PR missing Discord Discussion URL — will auto-close in 3 days labels May 22, 2026
@shaun-agent
Copy link
Copy Markdown
Contributor

shaun-agent commented May 22, 2026

OpenAB PR Screening

This is auto-generated by the OpenAB project-screening flow for context collection and reviewer handoff.
Click 👍 if you find this useful. Human review will be done within 24 hours. We appreciate your support and contribution 🙏

Screening report done. posted screening comment and moved the project item to `PR-Screening`.

GitHub comment: #903 (comment)
Project action: openabdev/1 item PVTI_lADOEFbZWM4BUUALzgtiSEQ moved Incoming -> PR-Screening

Intent

Forward configured MCP servers from OpenAB config into ACP sessions so deployers can make agent tools available without runtime-only host wiring. The operator-visible problem is missing or inconsistent MCP delivery to agent execution.

Feat

Feature. Adds [agent.mcp_servers], supports stdio/http/sse server definitions, sends ACP mcpServers on session/new and session/load, redacts MCP env/header values in debug logs, and documents/tests the config plus Helm rendering.

Who It Serves

Deployers and agent runtime operators first. Maintainers benefit from typed config, documented examples, and chart tests around a new integration surface.

Rewritten Prompt

Add typed MCP server configuration for agents. Parse stdio, HTTP, and SSE MCP definitions; render them from Helm values into config.toml; convert them into ACP mcpServers; include them in both new and loaded sessions; redact secret env/header values from debug logs without changing the outbound payload. Cover config parsing, ACP conversion, log redaction, and Helm rendering with focused tests and docs.

Merge Pitch

This fills a real MCP integration gap and keeps the behavior at the ACP boundary. Risk is moderate because it touches config, payload construction, Helm, and logging. Reviewers will likely focus on complete secret redaction and whether session/load forwarding is intentional for existing sessions.

Best-Practice Comparison

OpenClaw partially applies: this improves explicit delivery routing by carrying MCP config through the gateway/runtime payload. Durable job persistence, retries, isolated executions, and run logs are outside this PR.

Hermes Agent partially applies: session requests become more self-contained, which matches the scheduled-prompt principle. Daemon ticks, file locking, atomic state, and fresh scheduled sessions do not directly apply here.

Implementation Options

  1. Conservative: land config/docs first, then ACP forwarding after extra redaction tests. Lower runtime risk, slower user value.
  2. Balanced: merge this generic MCP forwarding PR after targeted review of redaction, session/load, and Helm output. Best immediate value.
  3. Ambitious: build full MCP runtime management with per-agent routing, probes, run logs, and failure reporting. Useful later, too broad now.

Comparison Table

Option Speed Complexity Reliability Maintainability User Impact Fit for OpenAB now
Conservative Medium Low High High Delayed Good if risk tolerance is low
Balanced Fast Medium Good with review Good Immediate Best fit
Ambitious Slow High Better later Risky now Strong later Poor as one PR

Recommendation

Take the balanced path. Have Masami or Pahud verify redaction and session/load semantics, then advance this PR. Keep runtime-specific MCP sync scripts, host units, and operational validation as follow-up PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants