feat(agent): forward configured MCP servers#903
Conversation
OpenAB PR ScreeningThis is auto-generated by the OpenAB project-screening flow for context collection and reviewer handoff.
Screening reportdone. posted screening comment and moved the project item to `PR-Screening`.GitHub comment: #903 (comment) IntentForward configured MCP servers from OpenAB config into ACP sessions so deployers can make agent tools available without runtime-only host wiring. The operator-visible problem is missing or inconsistent MCP delivery to agent execution. FeatFeature. Adds Who It ServesDeployers and agent runtime operators first. Maintainers benefit from typed config, documented examples, and chart tests around a new integration surface. Rewritten PromptAdd typed MCP server configuration for agents. Parse stdio, HTTP, and SSE MCP definitions; render them from Helm values into Merge PitchThis fills a real MCP integration gap and keeps the behavior at the ACP boundary. Risk is moderate because it touches config, payload construction, Helm, and logging. Reviewers will likely focus on complete secret redaction and whether Best-Practice ComparisonOpenClaw partially applies: this improves explicit delivery routing by carrying MCP config through the gateway/runtime payload. Durable job persistence, retries, isolated executions, and run logs are outside this PR. Hermes Agent partially applies: session requests become more self-contained, which matches the scheduled-prompt principle. Daemon ticks, file locking, atomic state, and fresh scheduled sessions do not directly apply here. Implementation Options
Comparison Table
RecommendationTake the balanced path. Have Masami or Pahud verify redaction and |
Discord Discussion URL: https://discord.com/channels/1504115981566345299/1507357234156540026/1507357234156540026
Summary
[agent.mcp_servers]config and convert stdio/http/sse MCP servers into ACPmcpServers.session/newandsession/load.Notes
Cargo.lockpackage version is synced from0.8.3to0.8.4because upstreamCargo.tomlalready reports0.8.4andcargo checkupdates the lockfile.Validation
cargo checkcargo test(403 passed)cargo clippy -- -D warningsgit diff --checkhelm lint charts/openabhelm template test charts/openabhelm template test charts/openab --set agents.kiro.enabled=falsehelm unittest charts/openab(10 suites / 100 tests passed)