fix: explicit routing on home controller (#155)

Author: lukedawilson

Examples/BookingSystem.AspNetCore.IdentityServer/Custom/Account/AccountController.cs

@@ -202,7 +202,7 @@ public async Task<IActionResult> Logout(LogoutInputModel model)
                 // build a return URL so the upstream provider will redirect back
                 // to us after the user has logged out. this allows us to then
                 // complete our single sign-out processing.
-                string url = Url.Action("Logout", new { logoutId = vm.LogoutId });
+                var url = Url.Action("Logout", new { logoutId = vm.LogoutId });
 
                 // this triggers a redirect to the external provider for sign-out
                 return SignOut(new AuthenticationProperties { RedirectUri = url }, vm.ExternalAuthenticationScheme);

Examples/BookingSystem.AspNetCore.IdentityServer/Custom/Home/HomeController.cs

@@ -1,7 +1,6 @@
 // Copyright (c) Brock Allen & Dominick Baier. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
 
-
 using IdentityServer4.Services;
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Hosting;
@@ -27,6 +26,7 @@ public HomeController(IIdentityServerInteractionService interaction, IWebHostEnv
             _logger = logger;
         }
 
+        [HttpGet("")]
         public IActionResult Index()
         {
             if (_environment.IsDevelopment())
@@ -35,18 +35,19 @@ public IActionResult Index()
                 return View();
             }
 
-            _logger.LogInformation("Homepage is disabled in production. Returning 404.");
+            _logger.LogInformation("Homepage is disabled in production - returning 404");
             return NotFound();
         }
 
         /// <summary>
         /// Shows the error page
         /// </summary>
+        [HttpGet("/error")]
         public async Task<IActionResult> Error(string errorId)
         {
             var vm = new ErrorViewModel();
 
-            // retrieve error details from identityserver
+            // retrieve error details from identity server
             var message = await _interaction.GetErrorContextAsync(errorId);
             if (message != null)
             {

Examples/BookingSystem.AspNetCore.IdentityServer/Startup.cs

@@ -50,6 +50,10 @@ public void Configure(IApplicationBuilder app)
             {
                 app.UseDeveloperExceptionPage();
             }
+            else
+            {
+                app.UseExceptionHandler("/error");
+            }
 
             app.UseIdentityServer();
 

Examples/BookingSystem.AspNetCore.IdentityServer/Views/Shared/Error.cshtml

@@ -3,7 +3,7 @@
 @{
     var error = Model?.Error?.Error;
     var errorDescription = Model?.Error?.ErrorDescription;
-    var request_id = Model?.Error?.RequestId;
+    var requestId = Model?.Error?.RequestId;
 }
 
 <div class="error-page">
@@ -12,29 +12,27 @@
     </div>
 
     <div class="row">
-        <div class="col-sm-6">
-            <div class="alert alert-danger">
-                Sorry, there was an error
+        <div class="alert alert-danger">
+            Sorry, there was an error
 
-                @if (error != null)
-                {
-                    <strong>
-                        <em>
-                            : @error
-                        </em>
-                    </strong>
+            @if (error != null)
+            {
+                <strong>
+                    <em>
+                        : @error
+                    </em>
+                </strong>
 
-                    if (errorDescription != null)
-                    {
-                        <div>@errorDescription</div>
-                    }
+                if (errorDescription != null)
+                {
+                    <div>@errorDescription</div>
                 }
-            </div>
-
-            @if (request_id != null)
-            {
-                <div class="request-id">Request Id: @request_id</div>
             }
         </div>
+
+        @if (requestId != null)
+        {
+            <div class="request-id">Request Id: @requestId</div>
+        }
     </div>
 </div>