Skip to content

Commit 92bcb97

Browse files
authored
feat: add try-catch to throw extra InvalidOpportunityOrOfferIdError (#196)
1 parent 1cbc00f commit 92bcb97

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,17 @@ private List<IOrderItemContext> GetOrderItemContexts(List<OrderItem> sourceOrder
489489
new IncompleteOrderItemError(), "acceptedOffer @id was not provided");
490490
}
491491

492-
var idComponents = base.ResolveOpportunityID(orderedItemId, acceptedOfferId);
492+
IBookableIdComponents idComponents;
493+
try
494+
{
495+
496+
idComponents = base.ResolveOpportunityID(orderedItemId, acceptedOfferId);
497+
}
498+
catch (RequiredBaseUrlMismatchException e)
499+
{
500+
throw new OpenBookingException(new InvalidOpportunityOrOfferIdError(), $"Opportunity @id or Offer @id does not originate from this system, {e.Message}. Opportunity @id '{orderedItemId}'; Offer @id '{acceptedOfferId}'");
501+
}
502+
493503

494504
if (idComponents == null)
495505
{

0 commit comments

Comments
 (0)