Fix logic issue (#159)

nickevansuk · web-flow · commit ecd88479e401 · 2021-08-05T11:50:37.000+01:00
diff --git a/OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs b/OpenActive.Server.NET/StoreBookingEngine/StoreBookingEngine.cs
@@ -197,7 +197,7 @@ public void SetResponseOrderItem(OrderItem item, SellerIdComponents sellerId, St
                 throw new OpenBookingException(new InternalLibraryError(), "Error property must not be set on OrderItem passed to SetResponseOrderItem");
             }
 
-            if (RequestOrderItem?.AcceptedOffer.Object?.Price == 0 && !(RequestOrderItem?.AcceptedOffer.Object?.OpenBookingPrepayment == null || RequestOrderItem?.AcceptedOffer.Object?.OpenBookingPrepayment == RequiredStatusType.Unavailable))
+            if (item?.AcceptedOffer.Object?.Price == 0 && !(item?.AcceptedOffer.Object?.OpenBookingPrepayment == null || item?.AcceptedOffer.Object?.OpenBookingPrepayment == RequiredStatusType.Unavailable))
             {
                 throw new OpenBookingException(new InternalLibraryError(), "OpenBookingPrepayment must be set to null or Unavailable for free opportunities.");
             }

Original file line number	Diff line number	Diff line change
`@@ -197,7 +197,7 @@ public void SetResponseOrderItem(OrderItem item, SellerIdComponents sellerId, St`
`197`	`197`	`throw new OpenBookingException(new InternalLibraryError(), "Error property must not be set on OrderItem passed to SetResponseOrderItem");`
`198`	`198`	`}`
`199`	`199`
`200`		`- if (RequestOrderItem?.AcceptedOffer.Object?.Price == 0 && !(RequestOrderItem?.AcceptedOffer.Object?.OpenBookingPrepayment == null \|\| RequestOrderItem?.AcceptedOffer.Object?.OpenBookingPrepayment == RequiredStatusType.Unavailable))`
	`200`	`+ if (item?.AcceptedOffer.Object?.Price == 0 && !(item?.AcceptedOffer.Object?.OpenBookingPrepayment == null \|\| item?.AcceptedOffer.Object?.OpenBookingPrepayment == RequiredStatusType.Unavailable))`
`201`	`201`	`{`
`202`	`202`	`throw new OpenBookingException(new InternalLibraryError(), "OpenBookingPrepayment must be set to null or Unavailable for free opportunities.");`
`203`	`203`	`}`