Merge pull request #60 from nathansalter/fix-schema-context

nathansalter · web-flow · commit f8b8a0cfa53e · 2020-10-12T12:42:42.000+01:00
Correct ending slash for schema.org
diff --git a/src/Helpers/JsonLd.php b/src/Helpers/JsonLd.php
@@ -75,7 +75,7 @@ public static function prepareDataForSerialization($obj, $parent = null, $schema
             )
         ) {
             $data["@context"] = array_merge(
-                $schema ? ['https://schema.org'] : [],
+                $schema ? ['https://schema.org/'] : [],
                 static::$defaultContext
             );
         }
diff --git a/tests/Unit/ExampleEventTest.php b/tests/Unit/ExampleEventTest.php
@@ -106,7 +106,7 @@ public function testSchemaContext()
 
         $decoded = json_decode($encode, true);
 
-        $this->assertContains("https://schema.org", $decoded["@context"]);
+        $this->assertContains("https://schema.org/", $decoded["@context"]);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public static function prepareDataForSerialization($obj, $parent = null, $schema`
`75`	`75`	`)`
`76`	`76`	`) {`
`77`	`77`	`$data["@context"] = array_merge(`
`78`		`- $schema ? ['https://schema.org'] : [],`
	`78`	`+ $schema ? ['https://schema.org/'] : [],`
`79`	`79`	`static::$defaultContext`
`80`	`80`	`);`
`81`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ public function testSchemaContext()`
`106`	`106`
`107`	`107`	`$decoded = json_decode($encode, true);`
`108`	`108`
`109`		`- $this->assertContains("https://schema.org", $decoded["@context"]);`
	`109`	`+ $this->assertContains("https://schema.org/", $decoded["@context"]);`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`/**`