fix stack overflow, (openapi-processor/openapi-processor-spring#435)

Author: hauner

openapi-processor-core/src/main/kotlin/io/openapiprocessor/core/writer/java/BeanValidationFactory.kt

@@ -30,19 +30,22 @@ open class BeanValidationFactory(
     }
 
     fun validate(dataType: DataType, required: Boolean = false, parentHasValid: Boolean = false): BeanValidationInfo {
-        return if (dataType is CollectionDataType) {
-            val (annotations, valid) = collectAnnotationsWithValid(dataType, required, parentHasValid)
-
-            BeanValidationInfoCollection(
-                dataType,
-                annotations,
-                validate(dataType.item, parentHasValid = valid)
-            )
-        } else {
-            BeanValidationInfoSimple(
-                dataType,
-                collectAnnotations(dataType, required, parentHasValid)
-            )
+        return when (dataType) {
+            is MappedCollectionDataTypePrimitive -> {
+                // should not be handled as collection, we can't annotate the primitive type only the primitve array
+                BeanValidationInfoSimple(dataType, collectAnnotations(dataType, required, parentHasValid))
+            }
+            is CollectionDataType -> {
+                val (annotations, valid) = collectAnnotationsWithValid(dataType, required, parentHasValid)
+
+                BeanValidationInfoCollection(
+                    dataType,
+                    annotations,
+                    validate(dataType.item, parentHasValid = valid))
+            }
+            else -> {
+                BeanValidationInfoSimple(dataType, collectAnnotations(dataType, required, parentHasValid))
+            }
         }
     }
 

openapi-processor-core/src/test/kotlin/io/openapiprocessor/core/writer/java/BeanValidationFactorySpec.kt

@@ -10,6 +10,7 @@ import io.kotest.core.spec.style.StringSpec
 import io.kotest.matchers.collections.shouldBeEmpty
 import io.kotest.matchers.shouldBe
 import io.openapiprocessor.core.converter.ApiOptions
+import io.openapiprocessor.core.converter.mapping.TypeMapping
 import io.openapiprocessor.core.model.datatypes.*
 import io.openapiprocessor.core.support.datatypes.ListDataType
 import io.openapiprocessor.core.support.datatypes.ObjectDataType
@@ -236,4 +237,37 @@ class BeanValidationFactorySpec : StringSpec({
         io.imports shouldBe setOf(validations.NOT_NULL, validations.VALID)
         io.annotations.shouldBeEmpty()
     }
+
+    "does apply validation annotations to mapped primitive collection" {
+        val sourceDataType = StringDataType(
+            constraints = DataTypeConstraints(format = "byte", minLength = 1, maxLength = 10), typeFormat = "string:byte")
+
+        val typeMapping = TypeMapping (
+            "byte",
+            null,
+            "byte",
+            emptyList(),
+            primitive = true,
+            primitiveArray = true)
+
+        val targetType = typeMapping.getTargetType()
+
+        val mappedDataType = MappedCollectionDataTypePrimitive(
+            targetType.getName(),
+            null,
+            false,
+            sourceDataType)
+
+        val info = validation.validate(mappedDataType, false)
+
+        val prop = info.prop
+        prop.dataTypeValue shouldBe "byte[]"
+        prop.imports shouldBe setOf(validations.SIZE)
+        prop.annotations shouldBe setOf("@Size(min = 1, max = 10)")
+
+        val io = info.inout
+        io.dataTypeValue shouldBe "@Size(min = 1, max = 10) byte[]"
+        io.imports shouldBe setOf(validations.SIZE)
+        io.annotations.shouldBeEmpty()
+    }
 })