remove unnecessary getter (#364)

Author: hauner

openapi-processor-core/src/main/kotlin/io/openapiprocessor/core/writer/java/DataTypeWriterBase.kt

@@ -324,7 +324,7 @@ abstract class DataTypeWriterBase(
         val target = getTarget(propData.propDataType)
 
         if (requiresJsonPropertyAnnotation(propData)) {
-            imports.addAll(jacksonAnnotations.getJsonProperty().imports)
+            imports.addAll(jacksonAnnotations.jsonProperty.imports)
         }
 
         if (apiOptions.beanValidation) {

openapi-processor-core/src/main/kotlin/io/openapiprocessor/core/writer/java/JacksonAnnotations.kt

@@ -9,9 +9,9 @@ import io.openapiprocessor.core.converter.ApiOptions
 import io.openapiprocessor.core.model.Annotation
 
 class JacksonAnnotations(apiOptions: ApiOptions) {
-    private val jsonProperty: Annotation
-    private val jsonCreator: Annotation
-    private val jsonValue: Annotation
+    val jsonProperty: Annotation
+    val jsonCreator: Annotation
+    val jsonValue: Annotation
 
     init {
         when (getJacksonFormat(apiOptions)) {
@@ -28,10 +28,6 @@ class JacksonAnnotations(apiOptions: ApiOptions) {
         }
     }
 
-    fun getJsonProperty(): Annotation = jsonProperty
-    fun getJsonCreator(): Annotation = jsonCreator
-    fun getJsonValue(): Annotation = jsonValue
-
     private fun getJacksonFormat(options: ApiOptions): JacksonFormat {
         return when (options.jackson) {
             "v2" -> JacksonFormat.V2

openapi-processor-core/src/main/kotlin/io/openapiprocessor/core/writer/java/StringEnumWriter.kt

@@ -102,8 +102,8 @@ open class StringEnumWriter(
 
     private fun collectImports(packageName: String, dataType: DataType): List<String> {
         val imports = mutableSetOf<String>()
-        imports.addAll(jacksonAnnotations.getJsonCreator().imports)
-        imports.addAll(jacksonAnnotations.getJsonValue().imports)
+        imports.addAll(jacksonAnnotations.jsonCreator.imports)
+        imports.addAll(jacksonAnnotations.jsonValue.imports)
         imports.addAll(generatedWriter.getImports())
         imports.addAll(dataType.referencedImports)
         if (isSupplier()) {

openapi-processor-core/src/test/kotlin/io/openapiprocessor/core/writer/java/DataTypeWriterPojoSpec.kt

@@ -881,7 +881,7 @@ class DataTypeWriterPojoSpec: StringSpec({
 
         writer.write(target, dataType)
 
-        verify { jackson.getJsonProperty() }
+        verify { jackson.jsonProperty }
     }
 
 })

openapi-processor-core/src/test/kotlin/io/openapiprocessor/core/writer/java/DataTypeWriterRecordSpec.kt

@@ -587,7 +587,7 @@ class DataTypeWriterRecordSpec: StringSpec({
 
         writer.write(target, dataType)
 
-        verify { jackson.getJsonProperty() }
+        verify { jackson.jsonProperty }
     }
 })
 

openapi-processor-core/src/test/kotlin/io/openapiprocessor/core/writer/java/JacksonAnnotationsSpec.kt

@@ -17,9 +17,9 @@ class JacksonAnnotationsSpec: StringSpec({
 
         val jackson = JacksonAnnotations(options)
 
-        jackson.getJsonProperty().imports shouldContainExactly setOf("com.fasterxml.jackson.annotation.JsonProperty")
-        jackson.getJsonCreator().imports shouldContainExactly setOf("com.fasterxml.jackson.annotation.JsonCreator")
-        jackson.getJsonValue().imports shouldContainExactly setOf("com.fasterxml.jackson.annotation.JsonValue")
+        jackson.jsonProperty.imports shouldContainExactly setOf("com.fasterxml.jackson.annotation.JsonProperty")
+        jackson.jsonCreator.imports shouldContainExactly setOf("com.fasterxml.jackson.annotation.JsonCreator")
+        jackson.jsonValue.imports shouldContainExactly setOf("com.fasterxml.jackson.annotation.JsonValue")
     }
 
     "provides jackson 3 annotations" {
@@ -28,8 +28,8 @@ class JacksonAnnotationsSpec: StringSpec({
 
         val jackson = JacksonAnnotations(options)
 
-        jackson.getJsonProperty().imports shouldContainExactly setOf("tools.jackson.annotation.JsonProperty")
-        jackson.getJsonCreator().imports shouldContainExactly setOf("tools.jackson.annotation.JsonCreator")
-        jackson.getJsonValue().imports shouldContainExactly setOf("tools.jackson.annotation.JsonValue")
+        jackson.jsonProperty.imports shouldContainExactly setOf("tools.jackson.annotation.JsonProperty")
+        jackson.jsonCreator.imports shouldContainExactly setOf("tools.jackson.annotation.JsonCreator")
+        jackson.jsonValue.imports shouldContainExactly setOf("tools.jackson.annotation.JsonValue")
     }
 })

openapi-processor-core/src/test/kotlin/io/openapiprocessor/core/writer/java/StringEnumWriterSpec.kt

@@ -37,7 +37,7 @@ class StringEnumWriterSpec : StringSpec({
 
         writer.write(target, dataType)
 
-        verify { jackson.getJsonCreator() }
-        verify { jackson.getJsonValue() }
+        verify { jackson.jsonCreator }
+        verify { jackson.jsonValue }
     }
 })