openapi-processor/openapi-processor-spring#157, additional parameter has no source type

Author: hauner

openapi-processor-core/src/main/kotlin/io/openapiprocessor/core/writer/java/BeanValidationFactory.kt

@@ -153,8 +153,9 @@ private fun DataType.shouldHaveValid(): Boolean {
     if (this is MappedCollectionDataType)
         return false
 
-    if (this is MappedSourceDataType)
-        return sourceDataType!!.shouldHaveValid()
+    if (this is MappedSourceDataType) {
+        return sourceDataType?.shouldHaveValid() ?: false
+    }
 
     return false
 }

openapi-processor-core/src/test/kotlin/io/openapiprocessor/core/writer/java/BeanValidationMappingSpec.kt

@@ -138,4 +138,27 @@ class BeanValidationMappingSpec: StringSpec({
         io.annotations.shouldBeEmpty()
     }
 
+    "does not add @Valid to data type without source type (additional parameter)" {
+        val dataType = MappedDataType(
+            "Foo",
+            "foo",
+            emptyList(),
+            emptyList(),
+            null,
+            false,
+            null
+        )
+
+        val info = validation.validate(dataType, false)
+
+        val prop = info.prop
+        prop.dataTypeValue shouldBe "Foo"
+        prop.imports.shouldBeEmpty()
+        prop.annotations.shouldBeEmpty()
+
+        val io = info.inout
+        io.dataTypeValue shouldBe "Foo"
+        io.imports.shouldBeEmpty()
+        io.annotations.shouldBeEmpty()
+    }
 })