fix ci action and address requested changes of the review.

Author: DivineThreepwood

.github/workflows/deploy-docker.yml

@@ -16,7 +16,7 @@ on:
 
 jobs:
   docker:
-    # if: ${{ github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'preview') }}
+    if: ${{ github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'preview') }}
     runs-on: ubuntu-latest
     outputs:
       bco-tags: ${{ steps.bco-meta.outputs.tags }}

module/dal/remote/src/main/java/org/openbase/bco/dal/remote/action/RemoteAction.java

@@ -619,7 +619,7 @@ public boolean isRunning() {
 
             try {
                 if (getActionDescription().getIntermediary()) {
-                    for (final RemoteAction impactedRemoteAction : impactedRemoteActions.stream().toList()) {
+                    for (final RemoteAction impactedRemoteAction : new ArrayList<>(impactedRemoteActions)) {
                         if (impactedRemoteAction.isRunning()) {
                             return true;
                         }
@@ -650,7 +650,7 @@ public boolean isDone() {
 
         try {
             if (getActionDescription().getIntermediary()) {
-                for (final RemoteAction impactedRemoteAction : impactedRemoteActions.stream().toList()) {
+                for (final RemoteAction impactedRemoteAction : new ArrayList<>(impactedRemoteActions)) {
                     if (!impactedRemoteAction.isDone()) {
                         return false;
                     }
@@ -854,7 +854,7 @@ private void cleanup() {
 
         // cleanup synchronisation and observation tasks
         actionDescriptionObservable.reset();
-        for (RemoteAction impactedRemoteAction : impactedRemoteActions.stream().toList()) {
+        for (RemoteAction impactedRemoteAction : new ArrayList<>(impactedRemoteActions)) {
             impactedRemoteAction.removeActionDescriptionObserver(impactActionObserver);
         }
         impactedRemoteActions.clear();
@@ -955,7 +955,7 @@ public void waitUntilDone() throws CouldNotPerformException, InterruptedExceptio
 
         try {
             if (getActionDescription().getIntermediary()) {
-                for (final RemoteAction impactedRemoteAction : impactedRemoteActions.stream().toList()) {
+                for (final RemoteAction impactedRemoteAction : new ArrayList<>(impactedRemoteActions)) {
                     impactedRemoteAction.waitUntilDone();
                 }
                 return;
@@ -1006,7 +1006,7 @@ public void waitForActionState(final ActionState.State actionState, final long t
 
         try {
             if (actionDescription.getIntermediary()) {
-                for (final RemoteAction impactedRemoteAction : impactedRemoteActions.stream().toList()) {
+                for (final RemoteAction impactedRemoteAction : new ArrayList<>(impactedRemoteActions)) {
                     impactedRemoteAction.waitForActionState(actionState, timeSplit.getTime(), timeSplit.getTimeUnit());
                 }
                 return;
@@ -1093,7 +1093,7 @@ public void waitForRegistration() throws CouldNotPerformException, InterruptedEx
             }
 
             if (getActionDescription().getIntermediary()) {
-                for (final RemoteAction impactedRemoteAction : impactedRemoteActions.stream().toList()) {
+                for (final RemoteAction impactedRemoteAction : new ArrayList<>(impactedRemoteActions)) {
                     impactedRemoteAction.waitForRegistration();
                 }
             }
@@ -1132,7 +1132,7 @@ public void waitForRegistration(final long timeout, final TimeUnit timeUnit) thr
             }
 
             if (getActionDescription().getIntermediary()) {
-                for (final RemoteAction impactedRemoteAction : impactedRemoteActions.stream().toList()) {
+                for (final RemoteAction impactedRemoteAction : new ArrayList<>(impactedRemoteActions)) {
                     impactedRemoteAction.waitForRegistration(timeSplit.getTime(), timeSplit.getTimeUnit());
                 }
             }
@@ -1149,7 +1149,7 @@ public boolean isRegistrationDone() {
             }
 
             if (actionDescription.getIntermediary()) {
-                for (final RemoteAction impactedRemoteAction : impactedRemoteActions.stream().toList()) {
+                for (final RemoteAction impactedRemoteAction : new ArrayList<>(impactedRemoteActions)) {
                     if (!impactedRemoteAction.isRegistrationDone()) {
                         return false;
                     }