Limit max string length snprintf

amandel · amandel · commit 0a8b7427ae3f · 2021-07-06T06:54:21.000+02:00
diff --git a/main/main.c b/main/main.c
@@ -81,7 +81,7 @@ static void logAppVersion(const esp_partition_t *partition) {
     char hash_print[HASH_LEN * 2 + 1];
     hash_print[HASH_LEN * 2] = 0;
     for (int i = 0; i < HASH_LEN; ++i) {
-        sprintf(&hash_print[i * 2], "%02x", app_desc.app_elf_sha256[i]);
+        snprintf(&hash_print[i * 2], 3, "%02x", app_desc.app_elf_sha256[i]);
     }
     ESP_LOGI(TAG, "App '%s', Version: '%s'", app_desc.project_name, app_desc.version);
     ESP_LOGI(TAG, "IDF-Version: '%s'", app_desc.idf_ver);

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ static void logAppVersion(const esp_partition_t *partition) {`
`81`	`81`	`char hash_print[HASH_LEN * 2 + 1];`
`82`	`82`	`hash_print[HASH_LEN * 2] = 0;`
`83`	`83`	`for (int i = 0; i < HASH_LEN; ++i) {`
`84`		`- sprintf(&hash_print[i * 2], "%02x", app_desc.app_elf_sha256[i]);`
	`84`	`+ snprintf(&hash_print[i * 2], 3, "%02x", app_desc.app_elf_sha256[i]);`
`85`	`85`	`}`
`86`	`86`	`ESP_LOGI(TAG, "App '%s', Version: '%s'", app_desc.project_name, app_desc.version);`
`87`	`87`	`ESP_LOGI(TAG, "IDF-Version: '%s'", app_desc.idf_ver);`