Skip to content

Commit f0836c5

Browse files
authored
feat: add userid to spans (#2536)
1 parent 3e6a1e6 commit f0836c5

3 files changed

Lines changed: 8 additions & 0 deletions

File tree

services/collaboration/pkg/middleware/tracing.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ func CollaborationTracingMiddleware(next http.Handler) http.Handler {
4141

4242
if wopiUser, ok := ctxpkg.ContextGetUser(r.Context()); ok {
4343
attrs = append(attrs, []attribute.KeyValue{
44+
attribute.String("enduser.id", wopiUser.GetId().GetOpaqueId()),
4445
attribute.String("cs3.user.idp", wopiUser.GetId().GetIdp()),
4546
attribute.String("cs3.user.opaque", wopiUser.GetId().GetOpaqueId()),
4647
attribute.String("cs3.user.type", wopiUser.GetId().GetType().String()),

services/proxy/pkg/middleware/account_resolver.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import (
1010
"github.com/opencloud-eu/opencloud/services/proxy/pkg/router"
1111
"github.com/opencloud-eu/opencloud/services/proxy/pkg/user/backend"
1212
"github.com/opencloud-eu/opencloud/services/proxy/pkg/userroles"
13+
"go.opentelemetry.io/otel/attribute"
1314
"go.opentelemetry.io/otel/trace"
1415

1516
cs3user "github.com/cs3org/go-cs3apis/cs3/identity/user/v1beta1"
@@ -235,6 +236,8 @@ func (m accountResolver) ServeHTTP(w http.ResponseWriter, req *http.Request) {
235236
}
236237
}
237238

239+
span.SetAttributes(attribute.String("enduser.id", user.GetId().GetOpaqueId()))
240+
238241
ri := router.ContextRoutingInfo(ctx)
239242
if ri.RemoteUserHeader() != "" {
240243
req.Header.Set(ri.RemoteUserHeader(), user.GetId().GetOpaqueId())

services/proxy/pkg/middleware/public_share_auth.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ import (
88
"github.com/opencloud-eu/opencloud/pkg/log"
99
revactx "github.com/opencloud-eu/reva/v2/pkg/ctx"
1010
"github.com/opencloud-eu/reva/v2/pkg/rgrpc/todo/pool"
11+
"go.opentelemetry.io/otel/attribute"
12+
"go.opentelemetry.io/otel/trace"
1113
)
1214

1315
const (
@@ -121,6 +123,8 @@ func (a PublicShareAuthenticator) Authenticate(r *http.Request) (*http.Request,
121123

122124
r.Header.Add(headerRevaAccessToken, authResp.Token)
123125

126+
trace.SpanFromContext(r.Context()).SetAttributes(attribute.String("enduser.id", "public"))
127+
124128
a.Logger.Debug().
125129
Str("authenticator", "public_share").
126130
Str("path", r.URL.Path).

0 commit comments

Comments
 (0)