Changed SPDM-Key Definiton for endorsed-csr (#37)

fdamato · web-flow · commit 8e631d90bd61 · 2025-07-29T11:20:02.000-07:00
Signed-off-by: Fabrizio Damato &lt;fabrizio.damato@amd.com&gt;
diff --git a/specifications/device-identity-provisioning/cddl/ocp-endorsed-csr.cddl b/specifications/device-identity-provisioning/cddl/ocp-endorsed-csr.cddl
@@ -0,0 +1,18 @@
+ocp-endorsed-csr = ocp-endorsed-csr-map / tagged-ocp-endorsed-csr
+
+tagged-ocp-endorsed-csr= #6.572(ocp-endorsed-csr) ; speculative because IANA registry is still pending
+
+; TODO: OCP will assign few attributes types but the field is not restricted to those
+
+ocp-endorsed-csr-map = {
+  &(key: 0) =>  [+ ocp-endorsed-csr-dict]
+}
+
+ocp-endorsed-csr-dict = {
+  &(id: 0) => uint
+  &(csr: 1) => bstr
+  &(attrib: 2) => [+ $key-attributes-type]
+}
+
+$key-attributes-type = tagged-oid-type
+
diff --git a/specifications/device-identity-provisioning/cddl/spdm-key.cddl b/specifications/device-identity-provisioning/cddl/spdm-key.cddl
diff --git a/specifications/device-identity-provisioning/diag/endorsed-csr-unsigned-all.diag b/specifications/device-identity-provisioning/diag/endorsed-csr-unsigned-all.diag
@@ -1,14 +1,16 @@
-/ tagged-spdm-key-map / 572( {
+/ ocp-endorsed-csr-map  / 572( {
    / key / 0 : [
     {
       / id / 0 : 0,
-      / attrib / 1: [
+      / csr / 1 :  h'59025630820252308201d9a003020102021431a4e0',
+      / attrib / 2: [
         / tagged-oid-type / 111(h'6086480186F84D010F046301')
         ]
     },
     {
       / id / 0 : 1,
-      / attrib / 1: [
+      / csr / 1 :  h'59025630820252308201d9a003020102021431a4e0',
+      / attrib / 2: [
         / tagged-oid-type / 111(h'6086480186F84D010F046301')
         ]
     }
diff --git a/specifications/device-identity-provisioning/spec.ocp b/specifications/device-identity-provisioning/spec.ocp
@@ -216,7 +216,8 @@ Table: GET_ENDORSED_CSR VendorDefinedReqPayload {#tbl:ecsr-req}
 | 6                   | Param1              | 1                   | KeyPairID. The value of this field           |
 |                     |                     |                     | shall be the keypair ID identifying          |
 |                     |                     |                     | the desired asymmetric key pair for          |
-|                     |                     |                     | which the CSR should be issued.              |
+|                     |                     |                     | which the CSR should be issued. if 0xFF      |
+|                     |                     |                     | returns a list of all availabe CSRs          |
 +---------------------+---------------------+---------------------+----------------------------------------------+
 | 7                   | Param2              | 1                   | Request Attributes. Shall adhere to          |
 |                     |                     |                     | Table 91 of SPDM 1.3.                        |

Original file line number	Diff line number	Diff line change
`@@ -1,14 +1,16 @@`
`1`		`-/ tagged-spdm-key-map / 572( {`
	`1`	`+/ ocp-endorsed-csr-map / 572( {`
`2`	`2`	`/ key / 0 : [`
`3`	`3`	`{`
`4`	`4`	`/ id / 0 : 0,`
`5`		`- / attrib / 1: [`
	`5`	`+ / csr / 1 : h'59025630820252308201d9a003020102021431a4e0',`
	`6`	`+ / attrib / 2: [`
`6`	`7`	`/ tagged-oid-type / 111(h'6086480186F84D010F046301')`
`7`	`8`	`]`
`8`	`9`	`},`
`9`	`10`	`{`
`10`	`11`	`/ id / 0 : 1,`
`11`		`- / attrib / 1: [`
	`12`	`+ / csr / 1 : h'59025630820252308201d9a003020102021431a4e0',`
	`13`	`+ / attrib / 2: [`
`12`	`14`	`/ tagged-oid-type / 111(h'6086480186F84D010F046301')`
`13`	`15`	`]`
`14`	`16`	`}`