Skip to content

Commit a721624

Browse files
committed
Misc fix-ups.
- Make OIDs plural throughout. - Update the diagram to refer to EAT. - Correct the EAT reference ID in bibliography.yaml. - Minor shuffling of references.
1 parent 5bfdb1a commit a721624

4 files changed

Lines changed: 17 additions & 19 deletions

File tree

specifications/device-identity-provisioning/bibliography.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ references:
3232
month: 5
3333
url: "https://datatracker.ietf.org/doc/html/rfc8392"
3434
- id: ietf-eat
35-
title: "RATS Entity Attestation Token"
35+
title: "Entity Attestation Token"
3636
publisher: "IETF"
3737
issued:
3838
year: 2025

specifications/device-identity-provisioning/diagrams/envelope_signed_csr.drawio.svg

Lines changed: 4 additions & 4 deletions
Loading

specifications/device-identity-provisioning/diagrams/envelope_signed_csr_non_self_signed.drawio.svg

Lines changed: 6 additions & 8 deletions
Loading

specifications/device-identity-provisioning/spec.ocp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -180,15 +180,15 @@ TODO: fill in
180180

181181
To allow a remote party to establish trust in a selected keypair, the device can emit a Certification Signing Request (CSR) [@{pkcs-10}]. This is supported in SPDM 1.3 [@{spdm-1.3}] via the GET_CSR command. However, there is a drawback to GET_CSR as it is currently defined: the CSR is signed only by the subject key, and does not include a way to attest that the CSR was emitted from a given device.
182182

183-
To allow a device to attest that a given key is trustworthy, the device should issue its own signature over the public key, which can include a freshness nonce and additional metadata, such as the key's derivation attribute OID.
183+
To allow a device to attest that a given key is trustworthy, the device should issue its own signature over the public key, which can include a freshness nonce and additional metadata, such as the key's derivation attribute OIDs.
184184

185185
![Envelope-signed CSR](./diagrams/envelope_signed_csr.drawio.svg){#fig:envelope-signed-csr}
186186

187-
The CSR is included as a claim of a CBOR Web Token [@{ietf-cwt}].
187+
The CSR is included as a claim in an Entity Attestation Token (EAT) [@{ietf-eat}].
188188

189-
Metadata such as the key's derivation attribute OID can also be embedded in a CoRIM. The mechanism for this is out of scope of this specification.
189+
Metadata such as the key's derivation attribute OIDs can also be embedded in a CoRIM. The mechanism for this is out of scope of this specification.
190190

191-
Some devices may not support the generation of self-signed CSRs for certain keys in their identity key hierarchy, such as LDevID. To support such devices, this specification defines a "non-self-signed CSR", which includes the subject public key but an all-zeroes signature field. The non-self-signed CSR is still itself signed, by way of the Conceptual Message Wrapper.
191+
Some devices may not support the generation of self-signed CSRs for certain keys in their identity key hierarchy, such as LDevID. To support such devices, this specification defines a "non-self-signed CSR", which includes the subject public key but an all-zeroes signature field. The non-self-signed CSR is still itself signed, by way of the EAT.
192192

193193
![Envelope-signed Non-self-signed CSR](./diagrams/envelope_signed_csr_non_self_signed.drawio.svg){#fig:envelope-signed-csr-non-self-signed}
194194

@@ -298,7 +298,7 @@ Table: ENVELOPE_SIGNED_CSR VendorDefinedRespPayload {#tbl:ecsr-resp}
298298

299299
The EnvelopeSignedCSRdata shall adhere to the following requirements:
300300

301-
- The payload SHALL be an Entity Attestation Token (EAT) [@{ietf-rats-eat}] encoded as a CBOR Web Token (CWT) [@{ietf-cwt}].
301+
- The payload SHALL be an EAT encoded as a CBOR Web Token (CWT) [@{ietf-cwt}].
302302
- The EAT SHALL conform to the OCP Envelope-Signed CSR EAT profile (TODO: OCP to assign OID for this profile).
303303
- The EAT SHALL include standard claims for issuer identification and nonce for freshness verification.
304304
- The EAT SHALL include private claims[^private-claims] containing:
@@ -310,7 +310,7 @@ The EnvelopeSignedCSRdata shall adhere to the following requirements:
310310
- E.g., Slot 0's certificate chain would extend at least to the vendor-endorsed certificate over IDevID. A separate slot's certificate chain would extend at least to the certificate issued by the slot's configured PKI owner.
311311
- A device may report intermediate certificates for the slot's PKI owner if it is configured to do so.
312312

313-
[^private-claims]: RFC 8392 defines a private claim as one whose key value has an integer value < -65536.
313+
[^private-claims]: RFC 8392 [@{ietf-cwt}] defines a private claim as one whose key value has an integer value < -65536.
314314

315315
### Key Derivation Attribute OIDs {#sec:key-derivation-attribute-oids}
316316

0 commit comments

Comments
 (0)