icastats: Ignore unknown user in summary and all report

If icastats is used with option '--summary' and it encounters a statistics
shared memory segment for a user that no longer exists, it fails with
'get_stats_sum: : Success'. This is because getpwuid() fails, but does not
set errno, so that perror prints 'Success'.
Instead of failing, just ignore such shared memory segments for users that
do no longer exist.

A similar problem exists with option '--all', it stops iterating over the
statistics shared memory segments if it finds one for a non existing user.
Continue the loop to return statistics for additional users.
Also fix a problem when stats_mmap() fails in the loop to close the directory
file descriptor before returning NULL.

Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>

Author: ifranzki

src/icastats_shared.c

@@ -263,10 +263,8 @@ int get_stats_sum(stats_entry_t *sum)
 			int fd;
 			stats_entry_t *tmp;
 
-			if ((getpwuid(atoi(&direntp->d_name[9]))) == NULL) {
-				closedir(shmDir);
-				return 0;
-			}
+			if ((getpwuid(atoi(&direntp->d_name[9]))) == NULL)
+				continue;
 
 			if ((fd = shm_open(direntp->d_name, O_RDONLY, 0)) == -1) {
 				closedir(shmDir);
@@ -324,9 +322,9 @@ char *get_next_usr()
 			int uid = atoi(&direntp->d_name[9]);
 			struct passwd *pwd;
 			if ((pwd = getpwuid(uid)) == NULL)
-				return NULL;
+				continue;
 			if (stats_mmap(uid) == -1)
-				return NULL;
+				break;
 
 			return pwd->pw_name;
 		} else {