fix: rename remaining entity_key variables to entity_ref

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: kdmccormick

src/openedx_content/applets/backup_restore/toml.py

@@ -214,7 +214,7 @@ def toml_publishable_entity_version(version: PublishableEntityVersion) -> tomlki
     return version_table
 
 
-def toml_collection(collection: Collection, entity_keys: list[str]) -> str:
+def toml_collection(collection: Collection, entity_refs: list[str]) -> str:
     """
     Create a TOML representation of a collection.
 
@@ -232,7 +232,7 @@ def toml_collection(collection: Collection, entity_keys: list[str]) -> str:
     doc = tomlkit.document()
 
     entities_array = tomlkit.array()
-    entities_array.extend(entity_keys)
+    entities_array.extend(entity_refs)
     entities_array.multiline(True)
 
     collection_table = tomlkit.table()

src/openedx_content/applets/backup_restore/zipper.py

@@ -403,11 +403,11 @@ def create_zip(self, path: str) -> None:
             for collection in collections:
                 collection_hash_slug = self.get_entity_toml_filename(collection.collection_code)
                 collection_toml_file_path = collections_folder / f"{collection_hash_slug}.toml"
-                entity_keys_related = collection.entities.order_by("entity_ref").values_list("entity_ref", flat=True)
+                entity_refs_related = collection.entities.order_by("entity_ref").values_list("entity_ref", flat=True)
                 self.add_file_to_zip(
                     zipf,
                     collection_toml_file_path,
-                    toml_collection(collection, list(entity_keys_related)),
+                    toml_collection(collection, list(entity_refs_related)),
                     timestamp=collection.modified,
                 )
 

tests/openedx_content/applets/backup_restore/test_restore.py

@@ -193,12 +193,12 @@ def verify_collections(self, lp):
         assert collection.created_by is not None
         assert collection.created_by.username == "lp_user"
 
-        expected_entity_keys = [
+        expected_entity_refs = [
             "xblock.v1:html:e32d5479-9492-41f6-9222-550a7346bc37",
             "xblock.v1:problem:256739e8-c2df-4ced-bd10-8156f6cfa90b",
         ]
-        entity_keys = [entity.entity_ref for entity in collection.entities.all()]
-        assert set(entity_keys) == set(expected_entity_keys)
+        entity_refs = [entity.entity_ref for entity in collection.entities.all()]
+        assert set(entity_refs) == set(expected_entity_refs)
 
 
 class RestoreLearningPackageTest(RestoreTestCase):
@@ -470,7 +470,7 @@ def _serialize(self, extra=None, base=None):
         s.is_valid()
         return s
 
-    def test_legacy_entity_key_parsed(self):
+    def test_legacy_entity_ref_parsed(self):
         """Ulmo archives have no [entity.component] section; fall back to parsing the entity key."""
         s = self._serialize()
         assert s.is_valid(), s.errors
@@ -505,7 +505,7 @@ def test_component_section_overrides_key(self):
         assert s.validated_data["component_type"].name == "html"
         assert s.validated_data["component_code"] == "different_code"
 
-    def test_invalid_entity_key_format(self):
+    def test_invalid_entity_ref_format(self):
         """Entity key without enough colons raises a validation error."""
         s = self._serialize(base={
             "can_stand_alone": True,

tests/openedx_content/applets/components/test_api.py

@@ -342,8 +342,8 @@ def test_simple_get(self):
         with self.assertRaises(ObjectDoesNotExist):
             components_api.get_component(-1)
 
-    def test_publishing_entity_key_convention(self):
-        """Our mapping convention is {namespace}:{component_type}:{component_code}"""
+    def test_publishing_entity_ref_convention(self):
+        """entity_ref convention: {namespace}:{component_type}:{component_code}"""
         assert self.problem.entity_ref == "xblock.v1:problem:my_component"
 
     def test_stand_alone_flag(self):