Skip to content

Commit 688242a

Browse files
authored
refactor: remove unused builtinblock webpack entry points (#35299)
Most blocks built into edx-platform have a pair of webpack entry points, like this: * {BlockName}Display # js for student+author+public views * {BlockName}Editor # js for studio view Prior to a past build refactoring [1], these entry points were defined in an auto-genered webpack config file. In order to simplify the js build process, this config generation step was removed and the new file webpack.builtinblocks.config.js was checked directly into edx-platform. However, during that refactoring, pointless entry points were introduced for HtmlBlock subclasses About, CourseInfo, and StaticTab, all of which just use their superclass's JS. [1] #32481
1 parent af9ae77 commit 688242a

1 file changed

Lines changed: 0 additions & 36 deletions

File tree

webpack.builtinblocks.config.js

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,5 @@
11
module.exports = {
22
entry: {
3-
AboutBlockDisplay: [
4-
'./xmodule/js/src/xmodule.js',
5-
'./xmodule/js/src/html/display.js',
6-
'./xmodule/js/src/javascript_loader.js',
7-
'./xmodule/js/src/collapsible.js',
8-
'./xmodule/js/src/html/imageModal.js',
9-
'./xmodule/js/common_static/js/vendor/draggabilly.js'
10-
],
11-
AboutBlockEditor: [
12-
'./xmodule/js/src/xmodule.js',
13-
'./xmodule/js/src/html/edit.js'
14-
],
153
AnnotatableBlockDisplay: [
164
'./xmodule/js/src/xmodule.js',
175
'./xmodule/js/src/html/display.js',
@@ -33,18 +21,6 @@ module.exports = {
3321
'./xmodule/js/src/xmodule.js',
3422
'./xmodule/js/src/sequence/edit.js'
3523
],
36-
CourseInfoBlockDisplay: [
37-
'./xmodule/js/src/xmodule.js',
38-
'./xmodule/js/src/html/display.js',
39-
'./xmodule/js/src/javascript_loader.js',
40-
'./xmodule/js/src/collapsible.js',
41-
'./xmodule/js/src/html/imageModal.js',
42-
'./xmodule/js/common_static/js/vendor/draggabilly.js'
43-
],
44-
CourseInfoBlockEditor: [
45-
'./xmodule/js/src/xmodule.js',
46-
'./xmodule/js/src/html/edit.js'
47-
],
4824
CustomTagBlockDisplay: './xmodule/js/src/xmodule.js',
4925
CustomTagBlockEditor: [
5026
'./xmodule/js/src/xmodule.js',
@@ -104,18 +80,6 @@ module.exports = {
10480
'./xmodule/js/src/xmodule.js',
10581
'./xmodule/js/src/sequence/edit.js'
10682
],
107-
StaticTabBlockDisplay: [
108-
'./xmodule/js/src/xmodule.js',
109-
'./xmodule/js/src/html/display.js',
110-
'./xmodule/js/src/javascript_loader.js',
111-
'./xmodule/js/src/collapsible.js',
112-
'./xmodule/js/src/html/imageModal.js',
113-
'./xmodule/js/common_static/js/vendor/draggabilly.js'
114-
],
115-
StaticTabBlockEditor: [
116-
'./xmodule/js/src/xmodule.js',
117-
'./xmodule/js/src/html/edit.js'
118-
],
11983
VideoBlockDisplay: [
12084
'./xmodule/js/src/xmodule.js',
12185
'./xmodule/js/src/video/10_main.js'

0 commit comments

Comments
 (0)