Players Can Attack Nations in PVP Immunity Without the Nation Attacking Back

[noahschmal]

Describe the bug
In a match with PVP immunity, during the immunity time, players can attack nations, and the nations cannot attack the player back. Nations can attack each other.

To Reproduce
Steps to reproduce the behavior:

1. Start a game with PVP immunity
2. Attack a nation, and it will not attack back
3. Watch nations attack themselves
4. After immunity, nations will attack you

Expected behavior
Nations should follow the same PVP immunity that players have.

Screenshots
If applicable, add screenshots to help explain your problem.

As you can see, I have no alliances, and no troops, and I am not being attacked:

Desktop (please complete the following information):

• OS: Windows 11
• Browser: Chrome
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version 31.12

Additional context
Validated from Enzo's most recent video.

[github-actions]

Hi @noahschmal, thanks for opening this issue. It hasn't been approved by a maintainer yet — we'll get back to you shortly to either milestone it (approval) or close it.

— Automated. See CONTRIBUTING.md.

[noahschmal]

I've identified three potential ways to fix this problem:

• Option A: PVP Immunity affects nations the same as it does players. Players can't attack nations, nations can't attack players, and nations can't attack each other
• Option B: Nations aren't included in PVP immunity, but we restrict players from being able to attack/farm nations. This means nations will still attack each other during immunity
• Option C: Nations aren't considered players in PVP immunity, and can freely attack players. This means that the PVP immunity means literally only players, not nations, removing the ability to farm them since they will attack back

[iiamlewis]

@noahschmal (via Discord):

<@516828441065160714> What is your opinion on this?

[evanpelle]

I think option C is best, nations shouldn't be included in the pvp immunity. We don't even have the pvp immunity option in singleplayer.