failing tests

[effbiae]

This is no good.

One problem is the lack of a make test. In fact, the lack of a working jconsole without having to make install is a problem, too. In future, openj requires a make test report for at least linux and windows -- ideally, we borrow a build-and-test farm from somewhere to automate the checking of all pull requests on all platforms.

Nothing but bug-fixes or reverts until we're clean.

[tavmem]

2 questions:

1. In my limited experience with Autotools, every package I've attempted to build/run has required a "make install" command. Why is that a problem in the case of onenj?

2. When the tests failed for you, it appears that you used the Autotools process. Did you try the Cmake process, and if so, did you get a working jconsole when using Linux?

[tavmem]

Just an FYI: I took a fresh clone, and did an
sudo git checkout 784c872
which took me back to to the commit done on Feb 3, 2012 at 15:15:09

I tried the cmake process (on Gentoo Linux) and diid not get a working jconsole.

I took a fresh clone again, and tried the Autotools process (on Linux).
I got a working jconsole, but got 40 failed tests.

Conclusion: The cause of the problems is earlier than the Feb 3, 2012 commit done at 15:15:09

[effbiae]

Before make install, there is conventionally a make test. This implies it should be possible to run jconsole without make install.

I settled on using cmake.

Ta, jack.

Sent from my iPhone

On 02/04/2012, at 1:24 AM, Tom Szczesnyreply@reply.github.com wrote:

2 questions:

1. In my limited experience with Autotools, every package I've attempted to build/run has required a "make install" command. Why is that a problem in the case of onenj?

2. When the tests failed for you, it appears that you used the Autotools process. Did you try the Cmake process, and if so, did you get a working jconsole when using Linux?

---

Reply to this email directly or view it on GitHub:
#34 (comment)

[tavmem]

Figured out why I was not getting a working jconsole when using the cmake approach:
Neglected to run the "sudo make install" step.

[mlochbaum]

Compiling on Arch Linux 64-bit, I get segfaults on g000i, g222i, g331ins, g420, and gbpar.ijs. It looks like this happens when a lot of comparisons (and possible other boolean operators) are done using rank. I'll look into the special code for =, >:, etc. when I have the chance.

I get testing failures on 23 files, but I never got a clean build with this source, and this doesn't seem like more than I had in the beginning.

We need a place to post, compare, sort, and address test results. What does Github have to accommodate this?

[effbiae]

gIthub doesn't have much more than "issues", "messages" and "wiki" as far
as i can see.

i have reports that all test cases pass with the original source release,
so, somewhere, a bug or bugs have been introduced. priority is to see
which pulls introduced the failures.

ta, jack.

[tavmem]

I tried git checkout fd62083
which was done on May 19, 2011.

Using cmake: got segfault on gstack, and exit to bash.
Using autotoools: all tests completed with testing errors on 37 files.

[effbiae]

failures on git checkout 5f49d52eb7954f24d86641cae48868d03c56a834

which is from 28 Mar 2011:

BAD ddall
/home/jack/core/test/g128x5.ijs
/home/jack/core/test/g15x.ijs
/home/jack/core/test/g320ipt.ijs
/home/jack/core/test/g410.ijs
/home/jack/core/test/g421p.ijs
/home/jack/core/test/g7x5.ijs
/home/jack/core/test/gdll.ijs
/home/jack/core/test/gibs.ijs
/home/jack/core/test/gmbx.ijs
/home/jack/core/test/gmbx0.ijs
/home/jack/core/test/gmbx1.ijs
/home/jack/core/test/gmbx2.ijs
/home/jack/core/test/gmbx3.ijs
/home/jack/core/test/gmbx4.ijs
/home/jack/core/test/gmbx5.ijs
/home/jack/core/test/gmbx6.ijs
/home/jack/core/test/gmbxah.ijs
/home/jack/core/test/gmbxip.ijs
/home/jack/core/test/gmbxqz.ijs
/home/jack/core/test/gmbxx.ijs
/home/jack/core/test/gmmf.ijs

jack@ubuntu:~/core$ git diff CMakeLists.txt
diff --git a/CMakeLists.txt b/CMakeLists.txt
index e1c276e..fd38b68 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -52,7 +52,7 @@ endif ()

add_library(j SHARED ${libj_SRCS})

set_target_properties(j PROPERTIES COMPILE_FLAGS "-fPIC -O3 -fno-strict-aliasin

+target_link_libraries(j ${jconsole_LIBS})
add_executable(jconsole ${jconsole_SRCS})
target_link_libraries(jconsole ${jconsole_LIBS})

[effbiae]

using autoreconf -i on

git checkout 34bb7c0 #Mar 23

BAD ddall
/home/jack/core/test/g128x5.ijs
/home/jack/core/test/g15x.ijs
/home/jack/core/test/g320ipt.ijs
/home/jack/core/test/g410.ijs
/home/jack/core/test/g421p.ijs
/home/jack/core/test/g7x5.ijs
/home/jack/core/test/gdll.ijs
/home/jack/core/test/gibs.ijs
/home/jack/core/test/gmbx.ijs
/home/jack/core/test/gmbx0.ijs
/home/jack/core/test/gmbx1.ijs
/home/jack/core/test/gmbx2.ijs
/home/jack/core/test/gmbx3.ijs
/home/jack/core/test/gmbx4.ijs
/home/jack/core/test/gmbx5.ijs
/home/jack/core/test/gmbx6.ijs
/home/jack/core/test/gmbxah.ijs
/home/jack/core/test/gmbxip.ijs
/home/jack/core/test/gmbxqz.ijs
/home/jack/core/test/gmbxx.ijs
/home/jack/core/test/gmmf.ijs
/home/jack/core/test/gpoly.ijs
/home/jack/core/test/gxco.ijs

[tavmem]

Just as a check that nothing changed in my environment that is affecting the tests,
I reran the tests in my build from the Jsoftware tarball (which was furher modified with suggestions by Bill Lam).
I only get failures in 2 tests:
g300t, which are timing tests.
g331ins, which are space-used tests.
Errors in these test scripts can be ignored.

[tavmem]

With git checkout b7c66ba
(which is the original load of tarball on 7 Mar 2011 at 16:08:58), I get

tom@xps /usr/local/core $ sudo touch .c
tom@xps /usr/local/core $ sudo bin/build_jconsole
cc jconsole.c -o jconsole
/tmp/ccfIAADL.o: In function main': jconsole.c:(.text+0x223): undefined reference tojepath'
jconsole.c:(.text+0x232): undefined reference to jeload' jconsole.c:(.text+0x24c): undefined reference tojefail'
jconsole.c:(.text+0x334): undefined reference to jefirst' jconsole.c:(.text+0x351): undefined reference tojedo'
collect2: ld returned 1 exit status
make: ** [jconsole] Error 1
failed: jconsole NOT created

This indicates that the full tarball was not initially loaded, but this may have been rectified in later commits.

[tavmem]

tom@xps /usr/local/core $ sudo git checkout c75fa0a
Note: checking out 'c75fa0aeba92a3f8b3a36c6228a8993d80fb0485'.

HEAD is now at c75fa0a... builds jconsole
tom@xps /usr/local/core $ sudo touch .c
tom@xps /usr/local/core $ sudo bin/build_jconsole
cc jconsole.c -o jconsole
/tmp/cc7CbZMG.o: In function main': jconsole.c:(.text+0x223): undefined reference tojepath'
jconsole.c:(.text+0x232): undefined reference to jeload' jconsole.c:(.text+0x24c): undefined reference tojefail'
jconsole.c:(.text+0x334): undefined reference to jefirst' jconsole.c:(.text+0x351): undefined reference tojedo'
collect2: ld returned 1 exit status
make: ** [jconsole] Error 1
failed: jconsole NOT created

This is the commit of 7 Mar 2011 at 9:43 which is labelled "builds jconsole"
Not clear that any of the commit states will run a full set of tests w/o errors.

[tavmem]

12 Mar 2011 08:57:59 (Clean up minor whitespace issues). Get same results:

tom@xps /usr/local/core $ sudo git checkout 5084cb3
Note: checking out '5084cb33c824d2345e04c82bcc26b9ce7c33e800'.

HEAD is now at 5084cb3... Clean up minor whitespace issues.
tom@xps /usr/local/core $ sudo touch .c
tom@xps /usr/local/core $ sudo bin/build_jconsole
cc jconsole.c -o jconsole
/tmp/ccNGEojn.o: In function main': jconsole.c:(.text+0x223): undefined reference tojepath'
jconsole.c:(.text+0x232): undefined reference to jeload' jconsole.c:(.text+0x24c): undefined reference tojefail'
jconsole.c:(.text+0x334): undefined reference to jefirst' jconsole.c:(.text+0x351): undefined reference tojedo'
collect2: ld returned 1 exit status
make: ** [jconsole] Error 1
failed: jconsole NOT created

[tavmem]

BTW:
Regarding the comment by mlochbaum:
"We need a place to post, compare, sort, and address test results. What does Github have to accommodate this?"

The "Gist" capability in github looks like it may help here.

[tavmem]

In the initial load of the tarball into github, the "makefile" was not included.