RA-1928: LoginPageController to handle URLs with one "/" only. (#91)

* RA-1928 If only contains one "/" character, it till use the entire urlPath for the urlContextPath

* RA-1928 Change from http to https

* RA-1928 Change from http to https

* RA-1928 Undo changes from http to https

* RA-1928 New Test for LoginPageController.java

* RA-1928 Update test get_shouldRedirectUserToHomeIfAuthenticatedAndPathForOpenmrsWasGivenOnUrl

* RA-1928 Update constants name

* RA-1928 Renaming method

Author: icrc-jfigueiredo

omod/src/main/java/org/openmrs/module/referenceapplication/page/controller/LoginPageController.java

@@ -162,7 +162,7 @@ private boolean isUrlWithinOpenmrs(PageRequest pageRequest, String redirectUrl)
 				try {
 					URL url = new URL(redirectUrl);
 					String urlPath = url.getFile();
-					String urlContextPath = urlPath.substring(0, urlPath.indexOf('/', 1));
+					String urlContextPath = urlPath.substring(1).contains("/") ? urlPath.substring(0, urlPath.indexOf('/', 1)) : urlPath;
 					if (StringUtils.equals(pageRequest.getRequest().getContextPath(), urlContextPath)) {
 						return true;
 					}

omod/src/test/java/org/openmrs/module/referenceapplication/page/controller/LoginPageControllerTest.java

@@ -334,6 +334,33 @@ public void get_shouldRedirectUserToHomeIfAuthenticated() throws Exception {
 		assertNotEquals("redirect:" + redirectUrl, new LoginPageController().get(pageModel, uiUtilsWithoutTimezones, pageRequest, null, null,
 		    appFrameworkService, administrationService));
 	}
+
+	/**
+	 * @see LoginPageController#get(org.openmrs.ui.framework.page.PageModel,
+	 *      org.openmrs.ui.framework.UiUtils, org.openmrs.ui.framework.page.PageRequest, String,
+	 *      org.openmrs.api.LocationService,
+	 *      org.openmrs.module.appframework.service.AppFrameworkService,
+	 *      org.openmrs.api.AdministrationService)
+	 */
+	@Test
+	@Verifies(value = "should redirect user to home when user is authenticated if ? redirectUrl is for openrms, even if only have  '/openrms'", method = "get(PageModel,UiUtils,PageRequest)")
+	public void get_shouldRedirectUserToHomeIfAuthenticatedAndURLPathAreInOpenmrsScope() throws Exception {
+		when(Context.isAuthenticated()).thenReturn(true);
+		when(Context.getUserContext()).thenReturn(mock(UserContext.class));
+
+		final String REDIRECT_FULL_URL = "http://openmrs.org/openmrs";
+		final String REDIRECT_URL_TO_OPENMRS = "/openmrs";
+		MockHttpServletRequest request = new MockHttpServletRequest();
+		request.setContextPath(TEST_CONTEXT_PATH);
+		request.setParameter(REQUEST_PARAMETER_NAME_REDIRECT_URL, REDIRECT_FULL_URL);
+		PageRequest pageRequest = createPageRequest(request, null);
+		HttpSession httpSession = new MockHttpSession();
+		request.setSession(httpSession);
+
+		PageModel pageModel = new PageModel();
+		assertEquals("redirect:" + REDIRECT_URL_TO_OPENMRS, new LoginPageController().get(pageModel, uiUtilsWithoutTimezones, pageRequest, null, null,
+				appFrameworkService, administrationService));
+	}
 
 	/**
 	 * @see LoginPageController#post(String, String, Integer, LocationService, AdministrationService,