Prepare fastify update (#2140)

Part of OPS-3917

Author: MarceloRGonc

packages/server/api/src/app/app-connection/app-connection.controller.ts

@@ -258,6 +258,7 @@ const GetAppConnectionRequest = {
           { additionalProperties: true },
         ),
       ]),
+      [StatusCodes.BAD_REQUEST]: Type.Null(),
     },
   },
 };

packages/server/api/src/app/dashboards/dashboards-module.ts

@@ -88,6 +88,7 @@ const StatsRequest = {
     }),
     response: {
       [StatusCodes.OK]: WorkflowStats,
+      [StatusCodes.INTERNAL_SERVER_ERROR]: Type.Null(),
     },
   },
 };

packages/server/api/src/app/flows/flow/flow-version.controller.ts

@@ -42,6 +42,18 @@ export const flowVersionController: FastifyPluginAsyncTypebox = async (
             success: Type.Boolean(),
             message: Type.String(),
           }),
+          [StatusCodes.BAD_REQUEST]: Type.Object({
+            success: Type.Boolean(),
+            message: Type.String(),
+          }),
+          [StatusCodes.CONFLICT]: Type.Object({
+            success: Type.Boolean(),
+            message: Type.String(),
+          }),
+          [StatusCodes.INTERNAL_SERVER_ERROR]: Type.Object({
+            success: Type.Boolean(),
+            message: Type.String(),
+          }),
         },
       },
     },
@@ -58,6 +70,7 @@ export const flowVersionController: FastifyPluginAsyncTypebox = async (
             message:
               'It is not possible to update the flowId of a flow version',
           });
+          return;
         }
 
         await assertFlowVersionBelongsToProject(
@@ -70,6 +83,7 @@ export const flowVersionController: FastifyPluginAsyncTypebox = async (
             success: false,
             message: 'The flow version is locked',
           });
+          return;
         }
 
         if (
@@ -80,6 +94,7 @@ export const flowVersionController: FastifyPluginAsyncTypebox = async (
             success: false,
             message: 'The flow version has been updated by another user',
           });
+          return;
         }
 
         const userId = request.principal.id;

packages/server/api/src/app/project/project-controller.ts

@@ -5,7 +5,7 @@ import {
 import {
   ApplicationError,
   PrincipalType,
-  Project,
+  ProjectWithoutSensitiveData,
   SeekPage,
 } from '@openops/shared';
 import { getProjectScopedRoutePolicy } from '../core/security/route-policies/route-security-policy-factory';
@@ -56,8 +56,6 @@ export const userProjectController: FastifyPluginCallbackTypebox = (
   done();
 };
 
-const ProjectWithoutToken = Type.Omit(Project, ['tablesDatabaseToken']);
-
 const GetUserProjectRequestOptions = {
   config: {
     security: getProjectScopedRoutePolicy({
@@ -66,7 +64,9 @@ const GetUserProjectRequestOptions = {
   },
   schema: {
     response: {
-      200: ProjectWithoutToken,
+      200: ProjectWithoutSensitiveData,
+      401: Type.Null(),
+      404: Type.Null(),
     },
   },
 };
@@ -79,7 +79,7 @@ const ListUserProjectsRequestOptions = {
   },
   schema: {
     response: {
-      200: SeekPage(ProjectWithoutToken),
+      200: SeekPage(ProjectWithoutSensitiveData),
     },
   },
 };

packages/server/api/src/app/user-settings/user-settings.module.ts

@@ -70,6 +70,7 @@ const GetUserSettingsRequestOptions = {
     security: [SERVICE_KEY_SECURITY_OPENAPI],
     response: {
       [StatusCodes.OK]: UserSettingsDefinition,
+      [StatusCodes.NOT_FOUND]: Type.Null(),
     },
   },
 };