Make condition evaluation optional in the adapter

Author: ravikiranvm

packages/server/api/src/app/benchmark/provider-adapter.ts

@@ -49,10 +49,10 @@ export type ProviderAdapter = {
     method: string,
     context: WizardContext,
   ): Promise<BenchmarkWizardOption[]>;
-  evaluateCondition(
+  evaluateCondition?: (
     condition: string,
     context: WizardContext,
-  ): Promise<boolean>;
+  ) => Promise<boolean>;
 };
 
 const providers = new Map<string, ProviderAdapter>();

packages/server/api/src/app/benchmark/wizard.service.ts

@@ -44,7 +44,13 @@ async function resolveNextStep(
   if (!nextStepDef.conditional) {
     return nextStepDef;
   }
-  const conditionResult = await providerAdapter.evaluateCondition(
+  const evaluateCondition = providerAdapter.evaluateCondition;
+  if (!evaluateCondition) {
+    throwValidationError(
+      'Benchmark provider does not support conditional wizard steps',
+    );
+  }
+  const conditionResult = await evaluateCondition(
     nextStepDef.conditional.when,
     context,
   );

packages/server/api/test/unit/benchmark/wizard.service.test.ts

@@ -404,4 +404,62 @@ describe('resolveWizardNavigation', () => {
       adapters.delete('misconfig');
     }
   });
+
+  it('throws when next step has conditional but adapter has no evaluateCondition', async () => {
+    const noConditionAdapterConfig = {
+      provider: 'no-condition-fn' as const,
+      steps: [
+        {
+          id: 'a',
+          title: 'Step A',
+          selectionType: 'single' as const,
+          optionsSource: { type: 'dynamic' as const, method: 'listA' },
+          nextStep: 'b',
+        },
+        {
+          id: 'b',
+          title: 'Step B',
+          selectionType: 'single' as const,
+          conditional: {
+            when: 'showB',
+            onSuccess: {
+              optionsSource: {
+                type: 'static' as const,
+                values: [{ id: 'b1', displayName: 'B1' }],
+              },
+            },
+            onFailure: { skipToStep: 'c' },
+          },
+          nextStep: 'c',
+        },
+        {
+          id: 'c',
+          title: 'Step C',
+          selectionType: 'single' as const,
+          optionsSource: {
+            type: 'static' as const,
+            values: [{ id: 'c1', displayName: 'C1' }],
+          },
+        },
+      ],
+    };
+    const noConditionAdapter: ProviderAdapter = {
+      config: noConditionAdapterConfig,
+      resolveOptions: mockResolveOptions,
+    };
+    adapters.set('no-condition-fn', noConditionAdapter);
+    try {
+      await expect(
+        resolveWizardNavigation(
+          'no-condition-fn',
+          { currentStep: 'a' },
+          TEST_PROJECT_ID,
+        ),
+      ).rejects.toThrow(
+        /Benchmark provider does not support conditional wizard steps/,
+      );
+    } finally {
+      adapters.delete('no-condition-fn');
+    }
+  });
 });