Fix zod array parsing issue

Author: bigfluffycookie

packages/server/api/src/app/ai/mcp/llm-query-router.ts

@@ -244,12 +244,15 @@ function findFirstKeyInObject(
  * Attempts to repair a malformed JSON string by extracting the expected schema fields.
  * Returns null if the input cannot be parsed or repaired, so then ai sdk will throw an error.
  */
-const repairText = (text: string): string | null => {
+export const repairText = (text: string): string | null => {
   try {
     const parsedText = JSON.parse(text);
 
+    const rawToolNames = findFirstKeyInObject(parsedText, 'tool_names');
+    const toolNames = normalizeToolNames(rawToolNames);
+
     return JSON.stringify({
-      tool_names: findFirstKeyInObject(parsedText, 'tool_names') || [],
+      tool_names: toolNames,
       query_classification:
         findFirstKeyInObject(parsedText, 'query_classification') || [],
       reasoning: findFirstKeyInObject(parsedText, 'reasoning') || '',
@@ -260,3 +263,18 @@ const repairText = (text: string): string | null => {
     return null;
   }
 };
+
+export const normalizeToolNames = (value: unknown): string[] => {
+  if (Array.isArray(value)) {
+    return value;
+  }
+
+  if (typeof value === 'string') {
+    return value
+      .split(',')
+      .map((name) => name.trim())
+      .filter((name) => name.length > 0);
+  }
+
+  return [];
+};

packages/server/api/test/unit/mcp/llm-query-router-repair.test.ts

@@ -0,0 +1,60 @@
+import {
+  normalizeToolNames,
+  repairText,
+} from '../../../src/app/ai/mcp/llm-query-router';
+
+describe('normalizeToolNames', () => {
+  it('should return array as-is when input is already an array', () => {
+    expect(normalizeToolNames(['Tool1', 'Tool2'])).toEqual(['Tool1', 'Tool2']);
+  });
+
+  it('should split comma-separated string into array and trim whitespace', () => {
+    expect(normalizeToolNames('Tool1, Tool2, Tool3')).toEqual([
+      'Tool1',
+      'Tool2',
+      'Tool3',
+    ]);
+  });
+
+  it('should return empty array for invalid input', () => {
+    expect(normalizeToolNames(null)).toEqual([]);
+    expect(normalizeToolNames(undefined)).toEqual([]);
+  });
+});
+
+describe('repairText', () => {
+  it('should handle tool_names as comma-separated string (bug fix)', () => {
+    const input = JSON.stringify({
+      tool_names: 'Get_Run_Details, Get_Latest_Flow_Version_By_Id',
+      query_classification: ['openops', 'run_investigation'],
+      reasoning: 'Some reasoning',
+      user_facing_reasoning: 'User facing reasoning',
+    });
+
+    const result = repairText(input);
+    const parsed = JSON.parse(result || '{}');
+
+    expect(parsed.tool_names).toEqual([
+      'Get_Run_Details',
+      'Get_Latest_Flow_Version_By_Id',
+    ]);
+  });
+
+  it('should handle tool_names as an array (correct format)', () => {
+    const input = JSON.stringify({
+      tool_names: ['Tool1', 'Tool2'],
+      query_classification: ['general'],
+      reasoning: 'Some reasoning',
+      user_facing_reasoning: 'User facing reasoning',
+    });
+
+    const result = repairText(input);
+    const parsed = JSON.parse(result || '{}');
+
+    expect(parsed.tool_names).toEqual(['Tool1', 'Tool2']);
+  });
+
+  it('should return null for invalid JSON', () => {
+    expect(repairText('not valid json')).toBeNull();
+  });
+});