Fix JSON stringify exceptions in the logger (#1635)

Fixes OPS-3108.

Author: maor-rozenfeld

packages/server/shared/src/lib/logger/log-cleaner.ts

@@ -41,11 +41,7 @@ export const cleanLogEvent = (logEvent: any) => {
     } else if (typeof value === 'number') {
       eventData[key] = Math.round(value * 100) / 100;
     } else if (typeof value === 'object') {
-      try {
-        eventData[key] = truncate(JSON.stringify(value));
-      } catch (error) {
-        eventData[key] = `Logger error - could not stringify object. ${error}`;
-      }
+      eventData[key] = stringify(value);
     } else {
       eventData[key] = truncate(value);
     }
@@ -90,10 +86,16 @@ function extractErrorFields(
   eventData[errorKey + 'Name'] = truncate(name);
   if (value instanceof ApplicationError) {
     eventData[errorKey + 'Code'] = truncate(value.error.code);
-    eventData[errorKey + 'Params'] = truncate(
-      JSON.stringify(value.error.params),
-    );
+    eventData[errorKey + 'Params'] = stringify(value.error.params);
   } else if (context && Object.keys(context).length) {
-    eventData[errorKey + 'Context'] = truncate(JSON.stringify(context));
+    eventData[errorKey + 'Context'] = stringify(context);
+  }
+}
+
+function stringify(value: any) {
+  try {
+    return truncate(JSON.stringify(value));
+  } catch (error) {
+    return `Logger error - could not stringify object. ${error}`;
   }
 }

packages/server/shared/test/log-cleaner.test.ts

@@ -263,6 +263,48 @@ describe('log-cleaner', () => {
       });
     });
 
+    it('should handle error context with circular reference', () => {
+      const error = new Error('test error');
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      const circularContext: any = { key: 'value' };
+      circularContext.circular = circularContext;
+      Object.assign(error, circularContext);
+
+      const logEvent = {
+        event: error,
+      };
+
+      const result = cleanLogEvent(logEvent);
+
+      expect(result.event.errorContext).toMatch(
+        /^Logger error - could not stringify object\./,
+      );
+    });
+
+    it('should handle ApplicationError params with circular reference', () => {
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      const circularParams: any = {
+        message: 'test',
+        data: {},
+      };
+      circularParams.data.circular = circularParams;
+
+      const appError = new ApplicationError({
+        code: ErrorCode.ENTITY_NOT_FOUND,
+        params: circularParams,
+      });
+
+      const logEvent = {
+        event: appError,
+      };
+
+      const result = cleanLogEvent(logEvent);
+
+      expect(result.event.errorParams).toMatch(
+        /^Logger error - could not stringify object\./,
+      );
+    });
+
     it('should flatten error in correct fields by prefix', () => {
       const logEvent = {
         event: {