Improve error handling while fetching subscriptions

Author: ravikiranvm

packages/server/api/src/app/benchmark/providers/azure/azure-option-resolver.ts

@@ -49,10 +49,28 @@ async function getSubscriptionsList(
   });
 
   const credentials = (connection.value as CustomAuthConnectionValue)?.props;
-  const tokenResult = await authenticateUserWithAzure(credentials);
-  const subscriptions = await getAzureSubscriptionsList(
-    tokenResult.access_token,
-  );
+
+  if (!credentials || typeof credentials !== 'object') {
+    throwValidationError(
+      'Selected connection is misconfigured or missing Azure credentials.',
+    );
+  }
+
+  let subscriptions: { subscriptionId: string; displayName: string }[];
+  try {
+    const tokenResult = await authenticateUserWithAzure(credentials);
+    subscriptions = await getAzureSubscriptionsList(tokenResult.access_token);
+  } catch {
+    throwValidationError(
+      'Unable to retrieve Azure subscriptions with the provided connection details.',
+    );
+  }
+
+  if (subscriptions.length === 0) {
+    throwValidationError(
+      'No Azure subscriptions were returned for this connection. Check access and tenant configuration.',
+    );
+  }
 
   const imageLogoUrl = await getAuthProviderLogoUrl(
     connection.authProviderKey,

packages/server/api/test/unit/benchmark/providers/azure/azure-option-resolver.test.ts

@@ -1,4 +1,4 @@
-import { REGION_IMAGE_LOGO_URL } from '@openops/shared';
+import { ErrorCode, REGION_IMAGE_LOGO_URL } from '@openops/shared';
 
 import { resolveOptions } from '../../../../../src/app/benchmark/providers/azure/azure-option-resolver';
 
@@ -178,6 +178,61 @@ describe('resolveOptions (Azure)', () => {
     expect(result).toEqual([{ id: 'sub-1', displayName: 'One' }]);
   });
 
+  it('throws validation error when subscriptions list is empty', async () => {
+    mockGetOneOrThrow.mockResolvedValue({
+      authProviderKey: 'Azure',
+      value: {
+        type: 'CUSTOM_AUTH',
+        props: {
+          clientId: 'client_id',
+          clientSecret: 'client_secret',
+          tenantId: 'tenant',
+        },
+      },
+    });
+    mockAuthenticateUserWithAzure.mockResolvedValue({ access_token: 't' });
+    mockGetAzureSubscriptionsList.mockResolvedValue([]);
+
+    const rejection = resolveOptions('getSubscriptionsList', {
+      projectId,
+      provider,
+      benchmarkConfiguration: { connection: ['c1'] },
+    });
+    await expect(rejection).rejects.toMatchObject({
+      error: { code: ErrorCode.VALIDATION },
+    });
+    await expect(rejection).rejects.toThrow(
+      /No Azure subscriptions were returned for this connection/,
+    );
+  });
+
+  it('throws validation error when subscription listing fails', async () => {
+    mockGetOneOrThrow.mockResolvedValue({
+      authProviderKey: 'Azure',
+      value: {
+        type: 'CUSTOM_AUTH',
+        props: {
+          clientId: 'client_id',
+          clientSecret: 'client_secret',
+          tenantId: 'tenant',
+        },
+      },
+    });
+    mockAuthenticateUserWithAzure.mockRejectedValue(new Error('token failed'));
+
+    const rejection = resolveOptions('getSubscriptionsList', {
+      projectId,
+      provider,
+      benchmarkConfiguration: { connection: ['c1'] },
+    });
+    await expect(rejection).rejects.toMatchObject({
+      error: { code: ErrorCode.VALIDATION },
+    });
+    await expect(rejection).rejects.toThrow(
+      /Unable to retrieve Azure subscriptions with the provided connection details/,
+    );
+  });
+
   it('delegates to getAzureRegionsList and returns options with imageLogoUrl for getRegionsList', async () => {
     const regionsList = [
       { id: 'eastus', displayName: 'East US' },