Reduce function complexity from 20 to 15 allowed

Author: cezudas

packages/server/api/src/app/database/migrations/1741945618000-ReplaceSelectOptionsIdsWithNames.ts

@@ -121,40 +121,55 @@ async function updateJsonObject(
   obj: any,
   tablesServerContext: TablesServerContext,
 ): Promise<any> {
-  if (!obj || typeof obj !== 'object') return obj;
+  if (!obj || typeof obj !== 'object') {
+    return obj;
+  }
 
-  if (obj.input?.tableName) {
-    const fields = await getFieldsFromCache(
-      obj.input.tableName,
-      tablesServerContext,
-    );
+  await updateInputFields(obj, tablesServerContext);
+  await processObjectKeys(obj, tablesServerContext);
 
-    if (!fields) {
-      return obj;
-    }
+  return obj;
+}
+
+async function updateInputFields(
+  obj: any,
+  tablesServerContext: TablesServerContext,
+): Promise<void> {
+  if (!obj.input?.tableName) {
+    return;
+  }
 
-    if (obj.input.fieldsProperties?.fieldsProperties) {
-      for (const field of obj.input.fieldsProperties.fieldsProperties) {
-        if (!field.fieldName) {
-          continue;
-        }
+  const fields = await getFieldsFromCache(
+    obj.input.tableName,
+    tablesServerContext,
+  );
 
-        updateFieldValue(field, fields.get(field.fieldName));
-      }
+  if (!fields || !obj.input.fieldsProperties?.fieldsProperties) {
+    return;
+  }
+
+  for (const field of obj.input.fieldsProperties.fieldsProperties) {
+    if (field.fieldName) {
+      updateFieldValue(field, fields.get(field.fieldName));
     }
   }
+}
 
+async function processObjectKeys(
+  obj: any,
+  tablesServerContext: TablesServerContext,
+): Promise<void> {
   for (const key of Object.keys(obj)) {
     if (Array.isArray(obj[key])) {
-      for (const item of obj[key]) {
-        obj[key] = await updateJsonObject(item, tablesServerContext);
-      }
-    } else if (typeof obj[key] === 'object') {
+      obj[key] = await Promise.all(
+        obj[key].map((item: any) =>
+          updateJsonObject(item, tablesServerContext),
+        ),
+      );
+    } else if (typeof obj[key] === 'object' && obj[key] !== null) {
       obj[key] = await updateJsonObject(obj[key], tablesServerContext);
     }
   }
-
-  return obj;
 }
 
 function updateFieldValue(field: any, fieldMap?: Map<number, string>) {