Skip to content

Commit 6b9a581

Browse files
authored
Make security policy mandatory per endpoint (#2118)
Fixes OPS-3899.
1 parent 64b49db commit 6b9a581

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

packages/server/api/src/app/app.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,9 @@ export const setupApp = async (
114114
const openapiRoutePrefix = '/v1/openapi';
115115
app.addHook('onRoute', (route) => {
116116
if (route.url.startsWith(openapiRoutePrefix)) {
117-
route.config ??= {};
117+
route.config ??= {
118+
security: PUBLIC_ROUTE_POLICY,
119+
};
118120
route.config.skipAuth = true;
119121
route.config.security = PUBLIC_ROUTE_POLICY;
120122
}

packages/server/api/src/app/flows/flow/flow.controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ const UpdateFlowRequestOptions = {
288288
config: {
289289
security: getProjectScopedRoutePolicy({
290290
allowedPrincipals: [PrincipalType.USER, PrincipalType.SERVICE],
291-
permission: Permission.UPDATE_FLOW_STATUS,
291+
permission: Permission.WRITE_FLOW,
292292
}),
293293
},
294294
schema: {

packages/server/api/types/fastify.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ declare module 'fastify' {
1717
// eslint-disable-next-line @typescript-eslint/consistent-type-definitions
1818
export interface FastifyContextConfig {
1919
rawBody?: boolean;
20-
security?: RouteSecurityPolicy; // TODO change to mandatory
20+
security: RouteSecurityPolicy;
2121

2222
// TODO: Prepare deprecation of the following properties
2323
allowedPrincipals?: PrincipalType[];

0 commit comments

Comments
 (0)