Skip to content

Commit 6efaf64

Browse files
authored
Make benchmark-ready "Available workflows" list use available vertical space (#2058)
Fixes OPS-3845. https://www.loom.com/share/ade634d9e8674c8fac918415273af4a0
1 parent 4ef05d7 commit 6efaf64

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

packages/react-ui/src/app/features/benchmark/components/benchmark-wizard.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,11 @@ export const BenchmarkWizard = ({
163163
/>
164164
)}
165165
</WizardStep>
166-
<WizardStep value="benchmark-ready" key="benchmark-ready">
166+
<WizardStep
167+
value="benchmark-ready"
168+
key="benchmark-ready"
169+
className="flex flex-col flex-1 min-h-0"
170+
>
167171
{benchmarkCreateResult && (
168172
<BenchmarkReadyStep
169173
providerName={providerName}

packages/ui-components/src/components/benchmark/benchmark-workflow-list.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,16 @@ export const BenchmarkWorkflowList = ({
88
workflows: BenchmarkWorkflowBase[];
99
provider: string;
1010
}) => (
11-
<div>
11+
<div className="flex flex-col flex-1 min-h-0">
1212
<p className="font-medium text-sm mb-2">{t('Available workflows:')}</p>
13-
<ul className="list-disc pl-5 space-y-1 overflow-y-auto max-h-[120px]">
13+
<ul className="list-disc pl-5 space-y-1 overflow-y-auto min-h-0">
1414
{workflows.map((workflow) => (
1515
<li key={workflow.flowId} className="text-sm">
1616
{workflow.displayName}
1717
</li>
1818
))}
1919
</ul>
20-
<p className="text-xs text-muted-foreground mt-3 italic">
20+
<p className="text-xs text-muted-foreground mt-3 italic shrink-0">
2121
{t(
2222
'* Running the benchmark triggers {provider} API calls, which may result in a small charge from {provider} (typically not exceeding $0.03 per account).',
2323
{ provider },

0 commit comments

Comments
 (0)