Add date field

Author: bigfluffycookie

…-opportunities-table-campaign-id-seed.ts …s-opportunities-table-new-fields-seed.tspackages/server/api/src/app/database/seeds/openops-opportunities-table-campaign-id-seed.ts renamed to packages/server/api/src/app/database/seeds/openops-opportunities-table-new-fields-seed.ts packages/server/api/src/app/database/seeds/openops-opportunities-table-campaign-id-seed.ts renamed to packages/server/api/src/app/database/seeds/openops-opportunities-table-new-fields-seed.ts

@@ -11,23 +11,23 @@ import { SEED_OPENOPS_TABLE_NAME } from '../../openops-tables/template-tables/cr
 import { databaseConnection } from '../database-connection';
 import { applyToEachTablesDatabase } from './tables-database-iterator';
 
-const OPPORTUNITIES_CAMPAIGN_ID_SEED = 'OPP_CAMPAIGN_ID_SEED';
+const OPPORTUNITIES_NEW_FIELDS_SEED = 'OPP_NEW_FIELDS_SEED';
 
 const alreadyApplied = async (): Promise<boolean> => {
   const flagRepo = databaseConnection().getRepository(FlagEntity);
-  const flag = await flagRepo.findOneBy({ id: OPPORTUNITIES_CAMPAIGN_ID_SEED });
+  const flag = await flagRepo.findOneBy({ id: OPPORTUNITIES_NEW_FIELDS_SEED });
   return flag?.value === true;
 };
 
 const setFlag = async (): Promise<void> => {
   const flagRepo = databaseConnection().getRepository(FlagEntity);
-  await flagRepo.save({ id: OPPORTUNITIES_CAMPAIGN_ID_SEED, value: true });
+  await flagRepo.save({ id: OPPORTUNITIES_NEW_FIELDS_SEED, value: true });
 };
 
-export const seedOpportunitiesCampaignIdField = async (): Promise<void> => {
+export const seedOpportunitiesNewFields = async (): Promise<void> => {
   if (await alreadyApplied()) {
-    logger.info('Skip: Opportunities Campaign ID field already seeded', {
-      name: 'seedOpportunitiesCampaignIdField',
+    logger.info('Skip: Opportunities new fields already seeded', {
+      name: 'seedOpportunitiesNewFields',
     });
     return;
   }
@@ -44,11 +44,20 @@ export const seedOpportunitiesCampaignIdField = async (): Promise<void> => {
       }
 
       const tokenOrResolver = await resolveTokenProvider(tablesContext);
-      await makeOpenOpsTablesPost(
-        `api/database/fields/table/${table.id}/`,
-        { name: 'Campaign ID', type: 'text' },
-        createAxiosHeaders(tokenOrResolver),
-      );
+      const createField = (field: object) =>
+        makeOpenOpsTablesPost(
+          `api/database/fields/table/${table.id}/`,
+          field,
+          createAxiosHeaders(tokenOrResolver),
+        );
+
+      await createField({ name: 'Campaign ID', type: 'text' });
+      await createField({
+        name: 'Last status change at',
+        type: 'date',
+        date_format: 'ISO',
+        date_include_time: true,
+      });
     },
   );
 

packages/server/api/src/app/openops-tables/template-tables/create-opportunities-table.ts

@@ -129,11 +129,6 @@ export async function createOpportunitiesTable(
     type: 'long_text',
   });
 
-  await addField(tokenOrResolver, table.id, {
-    name: 'Campaign ID',
-    type: 'text',
-  });
-
   await addField(tokenOrResolver, table.id, {
     name: 'Creation time',
     type: 'created_on',
@@ -148,6 +143,18 @@ export async function createOpportunitiesTable(
     date_include_time: true,
   });
 
+  await addField(tokenOrResolver, table.id, {
+    name: 'Campaign ID',
+    type: 'text',
+  });
+
+  await addField(tokenOrResolver, table.id, {
+    name: 'Last status change at',
+    type: 'date',
+    date_format: 'ISO',
+    date_include_time: true,
+  });
+
   logger.debug(`[Seeding ${SEED_OPENOPS_TABLE_NAME} table] Done`);
 }
 

packages/server/api/src/main.ts

@@ -16,7 +16,7 @@ import { ensureTablesMcpEndpointExists } from './app/database/seeds/ensure-table
 import { seedFocusDataAggregationTemplateTable } from './app/database/seeds/openops-aggregated-costs-seed';
 import * as analytics from './app/database/seeds/openops-analytics-seed';
 import { seedKnownCostTypesByApplicationTable } from './app/database/seeds/openops-known-cost-types-by-application-seed';
-import { seedOpportunitiesCampaignIdField } from './app/database/seeds/openops-opportunities-table-campaign-id-seed';
+import { seedOpportunitiesNewFields } from './app/database/seeds/openops-opportunities-table-new-fields-seed';
 import { seedOpportunitesTemplateTable } from './app/database/seeds/openops-opportunities-table-seed';
 import { seedTimeseriesTemplateTable } from './app/database/seeds/openops-timeseries-table-seed';
 import { upsertAdminUser } from './app/database/seeds/seed-admin';
@@ -98,7 +98,7 @@ const main = async (): Promise<void> => {
 
     await seedTemplateTables();
     await seedOpportunitesTemplateTable();
-    await seedOpportunitiesCampaignIdField();
+    await seedOpportunitiesNewFields();
     await seedFocusDataAggregationTemplateTable();
     await seedKnownCostTypesByApplicationTable();
     await seedAutoInstancesShutdownTable();

packages/server/api/test/unit/openops-tables/create-opportunities-table.test.ts

@@ -129,6 +129,12 @@ describe('createOpportunityTable', () => {
         name: 'Campaign ID',
         type: 'text',
       },
+      {
+        name: 'Last status change at',
+        type: 'date',
+        date_format: 'ISO',
+        date_include_time: true,
+      },
     ];
 
     expect(openopsCommonMock.makeOpenOpsTablesPost).toHaveBeenCalledTimes(