Use redis sets instead of json arrays

Author: ravikiranvm

packages/server/api/src/app/ai/chat/ai-chat.service.ts

@@ -141,13 +141,7 @@ export const createChatContext = async (
     chatExpireTime,
   );
   const indexKey = userChatsIndexKey(userId, projectId);
-  const existing =
-    (await cacheWrapper.getSerializedObject<string[]>(indexKey)) ?? [];
-
-  if (!existing.includes(chatId)) {
-    existing.push(chatId);
-    await cacheWrapper.setSerializedObject(indexKey, existing, chatExpireTime);
-  }
+  await cacheWrapper.addToSet(indexKey, chatId, chatExpireTime);
 };
 
 export const getChatContext = async (
@@ -189,8 +183,7 @@ export const getAllChats = async (
   projectId: string,
 ): Promise<{ chatId: string; chatName: string }[]> => {
   const indexKey = userChatsIndexKey(userId, projectId);
-  const chatIds =
-    (await cacheWrapper.getSerializedObject<string[]>(indexKey)) ?? [];
+  const chatIds = await cacheWrapper.getSetMembers(indexKey);
 
   if (chatIds.length === 0) {
     return [];
@@ -239,14 +232,12 @@ export const deleteChatHistory = async (
   projectId: string,
 ): Promise<void> => {
   const indexKey = userChatsIndexKey(userId, projectId);
-  const [chatIds] = await Promise.all([
-    cacheWrapper.getSerializedObject<string[]>(indexKey),
+  await Promise.all([
     cacheWrapper.deleteKey(chatHistoryKey(chatId, userId, projectId)),
     cacheWrapper.deleteKey(chatToolsKey(chatId, userId, projectId)),
     cacheWrapper.deleteKey(chatContextKey(chatId, userId, projectId)),
+    cacheWrapper.removeFromSet(indexKey, chatId),
   ]);
-  const updatedIds = (chatIds ?? []).filter((id) => id !== chatId);
-  await cacheWrapper.setSerializedObject(indexKey, updatedIds);
 };
 
 /**

packages/server/shared/src/lib/cache/memory-wrapper.ts

@@ -73,6 +73,28 @@ const getBufferAndDelete = async (key: string): Promise<Buffer | null> => {
   throw new Error('Not implemented');
 };
 
+const addToSet = async (
+  key: string,
+  member: string,
+  expireInSeconds: number = DEFAULT_EXPIRE_TIME / 1000,
+): Promise<void> => {
+  const existing = (await getSerializedObject<string[]>(key)) ?? [];
+  if (!existing.includes(member)) {
+    existing.push(member);
+  }
+  await setSerializedObject(key, existing, expireInSeconds);
+};
+
+const removeFromSet = async (key: string, member: string): Promise<void> => {
+  const existing = (await getSerializedObject<string[]>(key)) ?? [];
+  const updated = existing.filter((id) => id !== member);
+  await setSerializedObject(key, updated);
+};
+
+const getSetMembers = async (key: string): Promise<string[]> => {
+  return (await getSerializedObject<string[]>(key)) ?? [];
+};
+
 export const memoryWrapper = {
   setKey,
   getKey,
@@ -84,4 +106,7 @@ export const memoryWrapper = {
   setSerializedObject,
   getSerializedObject,
   scanKeys,
+  addToSet,
+  removeFromSet,
+  getSetMembers,
 };

packages/server/shared/src/lib/cache/redis-wrapper.ts

@@ -59,6 +59,29 @@ async function setSerializedObject<T>(
   await setKey(key, JSON.stringify(obj), expireInSeconds);
 }
 
+const addToSet = async (
+  key: string,
+  member: string,
+  expireInSeconds?: number,
+): Promise<void> => {
+  const redis = getRedisClient();
+  await redis.sadd(key, member);
+
+  if (expireInSeconds && expireInSeconds > 0) {
+    await redis.expire(key, expireInSeconds);
+  }
+};
+
+const removeFromSet = async (key: string, member: string): Promise<void> => {
+  const redis = getRedisClient();
+  await redis.srem(key, member);
+};
+
+const getSetMembers = async (key: string): Promise<string[]> => {
+  const redis = getRedisClient();
+  return redis.smembers(key);
+};
+
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 async function getOrAdd<T, Args extends any[]>(
   key: string,
@@ -134,4 +157,7 @@ export const redisWrapper = {
   setSerializedObject,
   getSerializedObject,
   scanKeys,
+  addToSet,
+  removeFromSet,
+  getSetMembers,
 };