Merge branch 'main' into feat/rbac-refactor

Author: alexandrudanpop

packages/react-ui/src/app/features/flows/components/flow-status-toggle.tsx

@@ -4,6 +4,7 @@ import {
   Tooltip,
   TooltipContent,
   TooltipTrigger,
+  usePermissionMessage,
 } from '@openops/components/ui';
 import {
   Flow,
@@ -29,8 +30,10 @@ import {
 import { useAuthorization } from '@/app/common/hooks/authorization-hooks';
 import { blocksHooks } from '@/app/features/blocks/lib/blocks-hook';
 import { handleMutationError } from '@/app/interceptors/interceptor-utils';
-import { t } from 'i18next';
-import { getShortTriggerExplanation } from '../lib/flow-status-toggle-utils';
+import {
+  getFlowStatusToggleTooltip,
+  getShortTriggerExplanation,
+} from '../lib/flow-status-toggle-utils';
 
 type FlowStatusToggleProps = {
   flow: Flow;
@@ -50,6 +53,7 @@ const FlowStatusToggle = ({
   const userHasPermissionToToggleFlowStatus = checkAccess(
     Permission.UPDATE_FLOW_STATUS,
   );
+  const permissionMessage = usePermissionMessage();
 
   useEffect(() => {
     setIsChecked(flow.status === FlowStatus.ENABLED);
@@ -128,17 +132,17 @@ const FlowStatusToggle = ({
           sideOffset={10}
           className="max-w-[300px] whitespace-normal"
         >
-          {userHasPermissionToToggleFlowStatus
-            ? isNil(flow.publishedVersionId)
-              ? t('Please publish workflow first')
-              : isFlowPublished
-              ? getShortTriggerExplanation(
-                  flowVersion.trigger,
-                  triggerMetadata,
-                  flow,
-                )
-              : t('Workflow is off. It only runs if manually triggered.')
-            : t('Permission Needed')}
+          {getFlowStatusToggleTooltip({
+            userHasPermission: userHasPermissionToToggleFlowStatus,
+            isPublishedVersionAvailable: !isNil(flow.publishedVersionId),
+            isFlowPublished,
+            triggerExplanation: getShortTriggerExplanation(
+              flowVersion.trigger,
+              triggerMetadata,
+              flow,
+            ),
+            permissionMessage,
+          })}
         </TooltipContent>
       </Tooltip>
       {isLoading ? (

packages/react-ui/src/app/features/flows/lib/flow-status-toggle-utils.ts

@@ -3,6 +3,37 @@ import { Flow, Trigger, TriggerType } from '@openops/shared';
 import cronstrue from 'cronstrue/i18n';
 import i18n, { t } from 'i18next';
 
+const DEFAULT_PERMISSION_MESSAGE =
+  "You don't have permission to perform this action. Please contact a Workspace owner";
+
+export function getFlowStatusToggleTooltip({
+  userHasPermission,
+  isPublishedVersionAvailable,
+  isFlowPublished,
+  triggerExplanation,
+  permissionMessage,
+}: {
+  userHasPermission: boolean;
+  isPublishedVersionAvailable: boolean;
+  isFlowPublished: boolean;
+  triggerExplanation: string;
+  permissionMessage: string | undefined;
+}): string {
+  if (!userHasPermission) {
+    return permissionMessage ?? t(DEFAULT_PERMISSION_MESSAGE);
+  }
+
+  if (!isPublishedVersionAvailable) {
+    return t('Please publish workflow first');
+  }
+
+  if (isFlowPublished) {
+    return triggerExplanation;
+  }
+
+  return t('Workflow is off. It only runs if manually triggered.');
+}
+
 export function getShortTriggerExplanation(
   trigger: Trigger,
   triggerMetadata: StepMetadata | undefined,