Skip to content

Commit c847db9

Browse files
move comment to PR target
Former-commit-id: 3e90f5e
2 parents 79edcaa + a90c97d commit c847db9

3 files changed

Lines changed: 9 additions & 25 deletions

File tree

.github/pull_request_template.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@
1515
* [ ] This submission was written on a forked copy of openproblems
1616
* [ ] Nextflow test pipeline is passing on this base branch of this pull
1717
request (include link to passed test on NF Tower found in GitHub Actions summary: )
18-
* [ ] If this pull request is not ready for review (including passing the Nextflow test
19-
pipeline), I will open this PR as a draft (click on the down arrow next to the
20-
"Create Pull Request" button)
2118

2219
### Submission guidelines
2320

@@ -31,11 +28,6 @@
3128
This PR will be evaluated on the basis of the following checks:
3229

3330
* [ ] The task addresses a valid open problem in single-cell analysis
34-
* [ ] The latest version of master is merged and tested
35-
* [ ] The methods/metrics are imported to `__init__.py` and were tested in the pipeline
36-
* [ ] Method and metric decorators are annotated with paper title, year, author, code
37-
version, and date
38-
* [ ] The README gives an outline of the methods, metrics and datasets in the folder
3931
* [ ] The README provides a satisfactory task explanation (for new tasks)
4032
* [ ] The sample test data is appropriate to test implementation of all methods and
4133
metrics (for new tasks)

.github/workflows/pre-commit.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,7 @@ jobs:
1919
options: --user root
2020

2121
if: >-
22-
!endsWith(github.event.head_commit.message, '# ci skip') &&
23-
(
24-
startsWith(github.ref, 'refs/heads') ||
25-
github.event.pull_request.draft == false
26-
)
22+
!endsWith(github.event.head_commit.message, '# ci skip')
2723
2824
steps:
2925

.github/workflows/run_tests.yml

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ on:
66
- '*'
77
branches:
88
- '**'
9-
pull_request:
10-
types: [opened, synchronize, reopened, ready_for_review]
9+
pull_request_review:
10+
types:
11+
- 'submitted'
1112

1213
concurrency:
1314
group: ${{ github.workflow }}-${{ github.ref }}
@@ -21,10 +22,9 @@ jobs:
2122
!endsWith(github.event.head_commit.message, '# ci skip') &&
2223
!startsWith(github.ref, 'refs/heads/test_process') &&
2324
(
24-
github.event_name != 'pull_request' ||
25+
(github.event_name != 'pull_request_review') ||
2526
(
26-
github.event_name == 'pull_request' &&
27-
github.event.pull_request.draft == false &&
27+
github.event.review.state == 'approved' &&
2828
github.event.pull_request.head.repo.owner.id == github.event.pull_request.base.repo.owner.id
2929
)
3030
)
@@ -147,12 +147,8 @@ jobs:
147147
!startsWith(github.ref, 'refs/heads/test_process') &&
148148
!startsWith(github.ref, 'refs/heads/test_website') &&
149149
(
150-
github.event_name != 'pull_request' ||
151-
(
152-
github.event_name == 'pull_request' &&
153-
github.event.pull_request.draft == false &&
154-
github.actor != 'dependabot[bot]'
155-
)
150+
github.event_name != 'pull_request_review' ||
151+
github.event.review.state == 'approved'
156152
)
157153
158154
outputs:
@@ -374,7 +370,7 @@ jobs:
374370
always() &&
375371
!endsWith(github.event.head_commit.message, '# ci skip') &&
376372
needs.build_images.result == 'success' &&
377-
github.event_name != 'pull_request' &&
373+
github.event_name != 'pull_request_review' &&
378374
(
379375
needs.run_tester.result == 'success' ||
380376
needs.run_tester.result == 'skipped'

0 commit comments

Comments
 (0)